-
Notifications
You must be signed in to change notification settings - Fork 6k
Add Platform View Manager to Windows shell #50598
Changes from 1 commit
500e60c
8dd4543
ae0d049
5f14af0
200f13a
ed90810
5d410ff
484c8c1
b8fadd7
1d203f4
b9acc1a
35eb688
659ebd6
db2851b
db48ddd
f87ed96
42f976e
284b309
e000930
676868f
6e6ef7e
22a9e46
95a8498
1fa97f3
5453b29
dfa6b73
cde468e
585ca11
54d91a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1172,7 +1172,7 @@ TEST_F(FlutterWindowsEngineTest, ChannelListenedTo) { | |
|
|
||
| TEST_F(FlutterWindowsEngineTest, ReceivePlatformViewMessage) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From my understanding, this file is more for engine unit tests. Since this launches & runs a full app, should we move this to the integration tests in I don't feel strongly about this, feel free to keep as is.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems to me that this test is quite similar in most regards to the handful of unit tests immediately preceding it in this file. Would you disagree?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's probably fine to land as-is, but I do think we should probably do a followup evaluation of which tests belong where. We're definitely not super consistent and to be honest, I'm not sure we've ever drawn a really clear line (not just in the Windows embedder but also on macOS). |
||
| FlutterWindowsEngineBuilder builder{GetContext()}; | ||
| builder.SetDartEntrypoint("sendCreationMethod"); | ||
| builder.SetDartEntrypoint("sendCreatePlatformViewMethod"); | ||
| auto engine = builder.Build(); | ||
|
|
||
| EngineModifier modifier(engine.get()); | ||
yaakovschectman marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a permalink here. The line number will be wrong as the code continues to evolve