PR Feedback

ci/licenses_golden/licenses_flutter

@@ -7293,6 +7293,8 @@ ORIGIN: ../../../flutter/shell/platform/windows/platform_handler.cc + ../../../f
 ORIGIN: ../../../flutter/shell/platform/windows/platform_handler.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/windows/platform_view_manager.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/windows/platform_view_manager.h + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/shell/platform/windows/platform_view_plugin.cc + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/shell/platform/windows/platform_view_plugin.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/windows/public/flutter_windows.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/windows/sequential_id_generator.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/windows/sequential_id_generator.h + ../../../flutter/LICENSE
@@ -10183,6 +10185,8 @@ FILE: ../../../flutter/shell/platform/windows/platform_handler.cc
 FILE: ../../../flutter/shell/platform/windows/platform_handler.h
 FILE: ../../../flutter/shell/platform/windows/platform_view_manager.cc
 FILE: ../../../flutter/shell/platform/windows/platform_view_manager.h
+FILE: ../../../flutter/shell/platform/windows/platform_view_plugin.cc
+FILE: ../../../flutter/shell/platform/windows/platform_view_plugin.h
 FILE: ../../../flutter/shell/platform/windows/public/flutter_windows.h
 FILE: ../../../flutter/shell/platform/windows/sequential_id_generator.cc
 FILE: ../../../flutter/shell/platform/windows/sequential_id_generator.h

shell/platform/windows/platform_view_manager.h

@@ -20,25 +20,28 @@ enum class FocusChangeDirection {
   kBackward       // Keyboard focus moves backwards, e.g. Shift+TAB.
 };
 
-// Keeps track of registered platform view types and platform view instances,
-// and is responsible for processing and responding to platform view related
-// method invokations from the framework.
+// The platform method handler for platform view related communication between
+// the engine and the framework. This base class is derived by a concrete class
+// (i.e. PlatformViewPlugin) to provide implementation of its abstract virtual
+// methods.
 class PlatformViewManager {
  public:
   PlatformViewManager(BinaryMessenger* binary_messenger);
 
   virtual ~PlatformViewManager();
 
   // Add a new platform view instance to be lazily instantiated when it is next
-  // composited.
+  // composited. The manager will invoke Success when this method returns true,
+  // and invoke Error otherwise.
   virtual bool AddPlatformView(PlatformViewId id,
-                                         std::string_view type_name) = 0;
+                               std::string_view type_name) = 0;
 
   // The framework may invoke this method when keyboard focus must be given to
-  // the platform view.
+  // the platform view. The manager will invoke Success when this method returns
+  // true, and invoke Error otherwise.
   virtual bool FocusPlatformView(PlatformViewId id,
-                         FocusChangeDirection direction,
-                         bool focus) = 0;
+                                 FocusChangeDirection direction,
+                                 bool focus) = 0;
 
  private:
   std::unique_ptr<MethodChannel<EncodableValue>> channel_;

shell/platform/windows/platform_view_plugin.h

@@ -13,6 +13,8 @@
 
 namespace flutter {
 
+// The concrete implementation of PlatformViewManager that keeps track of
+// existing platform view types and instances, and handles their instantiation.
 class PlatformViewPlugin : public PlatformViewManager {
  public:
   PlatformViewPlugin(BinaryMessenger* messenger, TaskRunner* task_runner);
@@ -23,18 +25,26 @@ class PlatformViewPlugin : public PlatformViewManager {
   // has no associated platform view.
   std::optional<HWND> GetNativeHandleForId(PlatformViewId id) const;
 
-  // Create a queued platform view instance.
-  void InstantiatePlatformView(PlatformViewId id);
-
   // The runner-facing API calls this method to register a window type
   // corresponding to a platform view identifier supplied to the widget tree.
   void RegisterPlatformViewType(std::string_view type_name,
                                 const FlutterPlatformViewTypeEntry& type);
 
+  // Create a queued platform view instance after it has been added.
+  // id must correspond to an identifier that has already been added with
+  // AddPlatformView.
+  // This method will create the platform view within a task queued to the
+  // engine's TaskRunner, which will run on the UI thread.
+  void InstantiatePlatformView(PlatformViewId id);
+
   // | PlatformViewManager |
+  // type_name must correspond to a string that has already been registered
+  // with RegisterPlatformViewType.
   bool AddPlatformView(PlatformViewId id, std::string_view type_name) override;
 
   // | PlatformViewManager |
+  // id must correspond to an identifier that has already been added with
+  // AddPlatformView.
   bool FocusPlatformView(PlatformViewId id, FocusChangeDirection direction, bool focus) override;
 
  private: