Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error #50951

Merged
auto-submit merged 15 commits into from
Feb 27, 2024
Merged

[Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error #50951

Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
98092cf
test readback
Feb 24, 2024
6f0894b
Remove early reset.
Feb 24, 2024
7146563
do everything plus barrier.
Feb 24, 2024
9e95f3c
Update image_encoding_impeller.cc
Feb 24, 2024
3e2dcf4
Update image_encoding_impeller.cc
Feb 24, 2024
3fda4d4
add invalidate
Feb 24, 2024
2203bf4
Merge branch 'do_everything_plus_barrier' of github.com:jonahwilliams…
Feb 24, 2024
9fe20e6
handle void type with location.
Feb 25, 2024
9ce385d
Merge branch 'main' of github.com:flutter/engine into do_everything_p…
Feb 26, 2024
a071e9b
Merge branch 'main' into do_everything_plus_barrier
Feb 26, 2024
b23ac23
Merge branch 'main' into do_everything_plus_barrier
Feb 27, 2024
229f326
Merge branch 'main' into do_everything_plus_barrier
bdero Feb 27, 2024
4bea95f
Update content_context.h
Feb 27, 2024
0fe4433
Merge branch 'do_everything_plus_barrier' of github.com:jonahwilliams…
Feb 27, 2024
64c632e
add barriers to vk screenshotter.
Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impeller/entity/contents/content_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ class ContentContext {
///
// TODO(bdero): Remove this setting once StC is fully de-risked
// https://github.com/flutter/flutter/issues/123671
static constexpr bool kEnableStencilThenCover = true;
static constexpr bool kEnableStencilThenCover = false;

#if IMPELLER_ENABLE_3D
std::shared_ptr<scene::SceneContext> GetSceneContext() const;
Expand Down