Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove early reset.
  • Loading branch information
jonahwilliams committed Feb 24, 2024
commit 6f0894b46c62062b9d99bdc325853b3262da5dcd
13 changes: 2 additions & 11 deletions lib/ui/painting/image_encoding_impeller.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,13 @@ sk_sp<SkImage> ConvertBufferToSkImage(
const std::shared_ptr<impeller::DeviceBuffer>& buffer,
SkColorType color_type,
SkISize dimensions) {
auto buffer_view = impeller::DeviceBuffer::AsBufferView(buffer);

SkImageInfo image_info = SkImageInfo::Make(dimensions, color_type,
SkAlphaType::kPremul_SkAlphaType);

SkBitmap bitmap;
auto func = [](void* addr, void* context) {
auto buffer =
static_cast<std::shared_ptr<impeller::DeviceBuffer>*>(context);
buffer->reset();
delete buffer;
};
auto bytes_per_pixel = image_info.bytesPerPixel();
bitmap.installPixels(image_info, buffer->OnGetContents(),
dimensions.width() * bytes_per_pixel, func,
new std::shared_ptr<impeller::DeviceBuffer>(buffer));
dimensions.width() * bytes_per_pixel);
bitmap.setImmutable();

sk_sp<SkImage> raster_image = SkImages::RasterFromBitmap(bitmap);
Expand Down Expand Up @@ -157,7 +148,7 @@ void ImageEncodingImpeller::ConvertDlImageToSkImage(

impeller::DeviceBufferDescriptor buffer_desc;
buffer_desc.storage_mode = impeller::StorageMode::kHostVisible;
buffer_desc.readback = true;
buffer_desc.readback = false; // set to false for testing.
buffer_desc.size =
texture->GetTextureDescriptor().GetByteSizeOfBaseMipLevel();
auto buffer =
Expand Down