Skip to content

Move iOS Swift unit tests back to Cirrus #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stuartmorgan-g merged 7 commits into from
Feb 17, 2023
Merged

Move iOS Swift unit tests back to Cirrus #3221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5173c3
Move iOS Swift unit tests back to Cirrus, as they are hanging frequen…
stuartmorgan-g Feb 17, 2023
f785e45
Bump target device
stuartmorgan-g Feb 17, 2023
994ea8d
Try LUCI too, just to see if that was the issue
stuartmorgan-g Feb 17, 2023
9caef80
Create a simulator rather than relying on the right one being there
stuartmorgan-g Feb 17, 2023
b9320f8
Fix script permissions
stuartmorgan-g Feb 17, 2023
ccc9654
Use a simulator that's available on Cirrus
stuartmorgan-g Feb 17, 2023
4a6684f
Try to make both Cirrus and LUCI happy
stuartmorgan-g Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Try to make both Cirrus and LUCI happy
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Feb 17, 2023
commit 4a6684f458cdcc13af3ab04690aeb841c7e481e2
5 changes: 4 additions & 1 deletion .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,11 @@ task:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
# Create an iPhone 13, to match what is available on LUCI, since Pigeon tests
# currently have a hard-coded device.
create_simulator_script:
- .ci/scripts/create_simulator.sh
- xcrun simctl list
- xcrun simctl create "iPhone 13" com.apple.CoreSimulator.SimDeviceType.iPhone-13 com.apple.CoreSimulator.SimRuntime.iOS-16-0
local_tests_script:
# script/configs/linux_only_custom_test.yaml
# Custom tests need Chrome for these packages. (They run in linux-custom_package_tests)
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/tool/shared/test_suites.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ Future<int> _runIOSPluginUnitTests(String testPluginPath) async {
return runXcodeBuild(
'$examplePath/ios',
sdk: 'iphonesimulator',
destination: 'platform=iOS Simulator,name=iPhone 14',
destination: 'platform=iOS Simulator,name=iPhone 13',
extraArguments: <String>['test'],
);
}
Expand Down