-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[local_auth_android] Fix Android lint warnings #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e6666b6
fix: remove baseline
mgmix 2e85332
fix: remove unused resource files by android gradle lint
mgmix 5f58348
fix: lint warning
mgmix b52b4af
bump version
mgmix ea9396a
Merge branch 'main' into local-auth-android-lint
mgmix 700b774
bump version
mgmix 3c52dc2
fix: apply suggestions
mgmix aeb5b16
Merge branch 'main' into local-auth-android-lint
mgmix 9a6489a
Merge branch 'main' into local-auth-android-lint
mgmix f656c27
bump version
mgmix 27431f1
Merge branch 'main' into local-auth-android-lint
mgmix 38ded67
fix: apply suggestion
mgmix 552e85a
Merge branch 'main' into local-auth-android-lint
mgmix cee993a
bump version
mgmix b67c8de
Merge branch 'main' into local-auth-android-lint
mgmix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove unused resource files by android gradle lint
- Loading branch information
commit 2e85332863f282d06401560f012ebc051e34c3db
There are no files selected for viewing
16 changes: 0 additions & 16 deletions
16
.../local_auth/local_auth_android/android/src/main/res/drawable/fingerprint_initial_icon.xml
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
.../local_auth/local_auth_android/android/src/main/res/drawable/fingerprint_success_icon.xml
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
.../local_auth/local_auth_android/android/src/main/res/drawable/fingerprint_warning_icon.xml
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
packages/local_auth/local_auth_android/android/src/main/res/drawable/ic_done_white_24dp.xml
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
...local_auth/local_auth_android/android/src/main/res/drawable/ic_fingerprint_white_24dp.xml
This file was deleted.
Oops, something went wrong.
12 changes: 0 additions & 12 deletions
12
...cal_auth/local_auth_android/android/src/main/res/drawable/ic_priority_high_white_24dp.xml
This file was deleted.
Oops, something went wrong.
47 changes: 0 additions & 47 deletions
47
packages/local_auth/local_auth_android/android/src/main/res/layout/scan_fp.xml
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
packages/local_auth/local_auth_android/android/src/main/res/values/colors.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,6 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <!-- Fingerprint colors --> | ||
| <color name="warning_color">#E53935</color> | ||
| <color name="hint_color">#BDBDBD</color> | ||
| <color name="success_color">#43A047</color> | ||
| <color name="black_text">#212121</color> | ||
| <color name="grey_text">#757575</color> | ||
| </resources> |
1 change: 0 additions & 1 deletion
1
packages/local_auth/local_auth_android/android/src/main/res/values/dimens.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| <resources> | ||
| <dimen name="body_text_size">14sp</dimen> | ||
| <dimen name="medium_text_size">16sp</dimen> | ||
| <dimen name="huge_text_size">20sp</dimen> | ||
| </resources> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, since I looked through commit history to figure out why these unused resources were here, these were part of the initial implementation, but became unused in flutter/plugins#1621.