Skip to content

[local_auth_android] Fix Android lint warnings #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 15 commits into from
May 2, 2023
Merged

[local_auth_android] Fix Android lint warnings #3764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e6666b6
fix: remove baseline
mgmix Apr 20, 2023
2e85332
fix: remove unused resource files by android gradle lint
mgmix Apr 20, 2023
5f58348
fix: lint warning
mgmix Apr 20, 2023
b52b4af
bump version
mgmix Apr 20, 2023
ea9396a
Merge branch 'main' into local-auth-android-lint
mgmix Apr 22, 2023
700b774
bump version
mgmix Apr 22, 2023
3c52dc2
fix: apply suggestions
mgmix Apr 24, 2023
aeb5b16
Merge branch 'main' into local-auth-android-lint
mgmix Apr 25, 2023
9a6489a
Merge branch 'main' into local-auth-android-lint
mgmix Apr 25, 2023
f656c27
bump version
mgmix Apr 25, 2023
27431f1
Merge branch 'main' into local-auth-android-lint
mgmix Apr 25, 2023
38ded67
fix: apply suggestion
mgmix Apr 25, 2023
552e85a
Merge branch 'main' into local-auth-android-lint
mgmix Apr 28, 2023
cee993a
bump version
mgmix Apr 28, 2023
b67c8de
Merge branch 'main' into local-auth-android-lint
mgmix Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: remove baseline
  • Loading branch information
@mgmix
mgmix committed Apr 20, 2023
commit e6666b6b4f1a47b1d6e2d2a2b2d6133e9b5107f4
2 changes: 1 addition & 1 deletion packages/local_auth/local_auth_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ android {

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Copy link
Contributor

@camsim99 camsim99 Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@mgmix mgmix Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because it was set in the build.gradle of other pacakges. Now that I think about it, it's an unrelated change, so I think I'll change it back.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding it is also a no-op (which is why I didn't add it when I added sourceCompatibility); the default value of targetCompatibility is sourceCompatibility's value.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the record straight since I just learned that this is wrong: it's a no-op for some AGP (or maybe Gradle?) versions. For older versions leaving it out causes flutter/flutter#125482

But I'll be adding this (and enforcement that it's there) in a separate PR.

}

lintOptions {
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
baseline file("lint-baseline.xml")
}


Expand Down
246 changes: 0 additions & 246 deletions packages/local_auth/local_auth_android/android/lint-baseline.xml
View file
Open in desktop

This file was deleted.