-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[camerax] Implement resolution configuration #3799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
44d7828
Add resolution configuration
camsim99 6281eb5
dart side of impl
bparrishMines 9a74cd1
java impls
bparrishMines 03ef376
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 2a5c0fc
Fix implementation
camsim99 9001ab0
Small cleanup
camsim99 fd19de6
Fixing tests and cleanup minus plugin dart impl test
camsim99 c9b62ef
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 725be10
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 6389ae1
Work on Dart side -- tests, cleanup, bug id
camsim99 16770de
Fix java unit tests
camsim99 a8144fa
Fix typo
camsim99 aba4c34
Fix dart tests
camsim99 ca5604a
Add integration tests
camsim99 474745c
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 b778894
Add res support
camsim99 8d2cb3a
correct overrides
camsim99 a145afe
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 fd3ade2
Self review
camsim99 1dc6fbd
formatting
camsim99 fad7cbc
Undo strange change
camsim99 08edc4c
Fix dart unit tests
camsim99 1def519
Fix integration test
camsim99 5bab620
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 caf819e
Nits
camsim99 c775756
Update readme
camsim99 fabaab7
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 810cb54
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 60a47ed
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 474d84c
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 6f45ecb
Add comments to integration tests
camsim99 5c31de4
Merge branch 'camx_resconfig' of github.com:camsim99/packages into ca…
camsim99 e4134bd
Updated integration test comment
camsim99 bb35a61
start quality re-write
camsim99 5ac1c7c
Replace vid qual const with quality/qualitydata
camsim99 860b4db
Replace Quality indices with VideoQuality/VideoQualityData class
camsim99 5ea328e
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 a163f0e
Fix versionining
camsim99 2a9671e
Format
camsim99 0178493
run tests
camsim99 ff9bd3a
nits
camsim99 396091c
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 206fbb6
Fix changelog
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix integration test
- Loading branch information
commit 1def51944672c9ae5824e012fb9d29e27ff0318d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix for Long -> Integer casting issues that the integration test revealed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the issue? Its not clear to me why the previous code would fail - it looks like the logical change here is to go from: calling
intValue()on theLong, to: casting to aNumberand then using theintValue()implementation forNumberinstead.But I would expect either of those to work, and if they both did, would prefer the former. Does this only work with the cast to
Numberadded in?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using your former suggestion, this is an example of the error I got: https://firebase.corp.google.com/project/flutter-infra-staging/testlab/histories/bh.90e767c88242d274/matrices/6437969997948729501/executions/bs.a725e88a067fbf4d/testcases/2/test-cases.
I'm open to suggestions, but I could not find a fix and after investigating, it's unclear why I'm getting the error and only in the Firebase test lab like that. May be something with Java versions but unsure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this is an issue because I was trying to index an array with a Long, most likely. After talking to @reidbaker, I'm going to take his suggestion and rework how I send a
Qualityfrom Dart to Java rather than trying to send indices of enums that representQualitys.