Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
44d7828
Add resolution configuration
camsim99 Apr 22, 2023
6281eb5
dart side of impl
bparrishMines Apr 26, 2023
9a74cd1
java impls
bparrishMines Apr 26, 2023
03ef376
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 May 15, 2023
2a5c0fc
Fix implementation
camsim99 May 15, 2023
9001ab0
Small cleanup
camsim99 May 15, 2023
fd19de6
Fixing tests and cleanup minus plugin dart impl test
camsim99 May 17, 2023
c9b62ef
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Jul 18, 2023
725be10
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Jul 18, 2023
6389ae1
Work on Dart side -- tests, cleanup, bug id
camsim99 Jul 18, 2023
16770de
Fix java unit tests
camsim99 Jul 18, 2023
a8144fa
Fix typo
camsim99 Jul 18, 2023
aba4c34
Fix dart tests
camsim99 Jul 19, 2023
ca5604a
Add integration tests
camsim99 Jul 20, 2023
474745c
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Aug 16, 2023
b778894
Add res support
camsim99 Aug 16, 2023
8d2cb3a
correct overrides
camsim99 Aug 16, 2023
a145afe
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Aug 16, 2023
fd3ade2
Self review
camsim99 Aug 16, 2023
1dc6fbd
formatting
camsim99 Aug 16, 2023
fad7cbc
Undo strange change
camsim99 Aug 16, 2023
08edc4c
Fix dart unit tests
camsim99 Aug 16, 2023
1def519
Fix integration test
camsim99 Aug 17, 2023
5bab620
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Aug 17, 2023
caf819e
Nits
camsim99 Aug 17, 2023
c775756
Update readme
camsim99 Aug 17, 2023
fabaab7
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 Aug 22, 2023
810cb54
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 Aug 22, 2023
60a47ed
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 Aug 22, 2023
474d84c
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 Aug 22, 2023
6f45ecb
Add comments to integration tests
camsim99 Aug 22, 2023
5c31de4
Merge branch 'camx_resconfig' of github.com:camsim99/packages into ca…
camsim99 Aug 22, 2023
e4134bd
Updated integration test comment
camsim99 Aug 23, 2023
bb35a61
start quality re-write
camsim99 Aug 29, 2023
5ac1c7c
Replace vid qual const with quality/qualitydata
camsim99 Aug 29, 2023
860b4db
Replace Quality indices with VideoQuality/VideoQualityData class
camsim99 Aug 29, 2023
5ea328e
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Aug 29, 2023
a163f0e
Fix versionining
camsim99 Aug 29, 2023
2a9671e
Format
camsim99 Aug 29, 2023
0178493
run tests
camsim99 Aug 29, 2023
ff9bd3a
nits
camsim99 Sep 7, 2023
396091c
Merge remote-tracking branch 'upstream/main' into camx_resconfig
camsim99 Sep 7, 2023
206fbb6
Fix changelog
camsim99 Sep 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix dart tests
  • Loading branch information
camsim99 committed Jul 19, 2023
commit aba4c34d64f89550727ab8906b062a59e62de8f8
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,11 @@ void main() {
when(camera.testPreview.setSurfaceProvider())
.thenAnswer((_) async => testSurfaceTextureId);
when(mockProcessCameraProvider.bindToLifecycle(
camera.mockBackCameraSelector,
<UseCase>[camera.testPreview, camera.testImageCapture]))
.thenAnswer((_) async => mockCamera);
camera.mockBackCameraSelector, <UseCase>[
camera.testPreview,
camera.testImageCapture,
camera.testImageAnalysis
])).thenAnswer((_) async => mockCamera);
when(mockCamera.getCameraInfo()).thenAnswer((_) async => mockCameraInfo);
when(mockCameraInfo.getCameraState())
.thenAnswer((_) async => mockLiveCameraState);
Expand Down Expand Up @@ -246,9 +248,11 @@ void main() {
camera.processCameraProvider = mockProcessCameraProvider;

when(mockProcessCameraProvider.bindToLifecycle(
camera.mockBackCameraSelector,
<UseCase>[camera.testPreview, camera.testImageCapture]))
.thenAnswer((_) async => mockCamera);
camera.mockBackCameraSelector, <UseCase>[
camera.testPreview,
camera.testImageCapture,
camera.testImageAnalysis
])).thenAnswer((_) async => mockCamera);
when(mockCamera.getCameraInfo()).thenAnswer((_) async => mockCameraInfo);
when(mockCameraInfo.getCameraState())
.thenAnswer((_) async => MockLiveCameraState());
Expand All @@ -258,8 +262,12 @@ void main() {
enableAudio: enableAudio);

// Verify expected UseCases were bound.
verify(camera.processCameraProvider!.bindToLifecycle(camera.cameraSelector!,
<UseCase>[camera.testPreview, camera.testImageCapture]));
verify(camera.processCameraProvider!.bindToLifecycle(
camera.cameraSelector!, <UseCase>[
camera.testPreview,
camera.testImageCapture,
camera.testImageAnalysis
]));

// Verify the camera's CameraInfo instance got updated.
expect(camera.cameraInfo, equals(mockCameraInfo));
Expand All @@ -285,9 +293,11 @@ void main() {
camera.processCameraProvider = mockProcessCameraProvider;

when(mockProcessCameraProvider.bindToLifecycle(
camera.mockBackCameraSelector,
<UseCase>[camera.testPreview, camera.testImageCapture]))
.thenAnswer((_) async => mockCamera);
camera.mockBackCameraSelector, <UseCase>[
camera.testPreview,
camera.testImageCapture,
camera.testImageAnalysis
])).thenAnswer((_) async => mockCamera);
when(mockCamera.getCameraInfo()).thenAnswer((_) async => mockCameraInfo);
when(mockCameraInfo.getCameraState())
.thenAnswer((_) async => MockLiveCameraState());
Expand Down Expand Up @@ -389,9 +399,11 @@ void main() {
.thenAnswer((_) async => cameraId);

when(camera.processCameraProvider!.bindToLifecycle(
camera.mockBackCameraSelector,
<UseCase>[camera.testPreview, camera.testImageCapture]))
.thenAnswer((_) async => mockCamera);
camera.mockBackCameraSelector, <UseCase>[
camera.testPreview,
camera.testImageCapture,
camera.testImageAnalysis
])).thenAnswer((_) async => mockCamera);
when(mockCamera.getCameraInfo()).thenAnswer((_) async => mockCameraInfo);
when(mockCameraInfo.getCameraState())
.thenAnswer((_) async => MockLiveCameraState());
Expand Down Expand Up @@ -998,6 +1010,7 @@ void main() {

camera.processCameraProvider = mockProcessCameraProvider;
camera.cameraSelector = MockCameraSelector();
camera.imageAnalysis = MockImageAnalysis();

when(mockProcessCameraProvider.bindToLifecycle(any, any))
.thenAnswer((_) => Future<Camera>.value(mockCamera));
Expand Down Expand Up @@ -1031,6 +1044,7 @@ void main() {

camera.processCameraProvider = mockProcessCameraProvider;
camera.cameraSelector = MockCameraSelector();
camera.imageAnalysis = MockImageAnalysis();

when(mockProcessCameraProvider.bindToLifecycle(any, any))
.thenAnswer((_) => Future<Camera>.value(mockCamera));
Expand Down Expand Up @@ -1070,6 +1084,7 @@ void main() {
final ProcessCameraProvider mockProcessCameraProvider =
MockProcessCameraProvider();
final CameraSelector mockCameraSelector = MockCameraSelector();
final MockImageAnalysis mockImageAnalysis = MockImageAnalysis();
final Camera mockCamera = MockCamera();
final CameraInfo mockCameraInfo = MockCameraInfo();
final MockImageProxy mockImageProxy = MockImageProxy();
Expand All @@ -1084,11 +1099,12 @@ void main() {

camera.processCameraProvider = mockProcessCameraProvider;
camera.cameraSelector = mockCameraSelector;
camera.imageAnalysis = mockImageAnalysis;

when(mockProcessCameraProvider.isBound(camera.mockImageAnalysis))
when(mockProcessCameraProvider.isBound(mockImageAnalysis))
.thenAnswer((_) async => Future<bool>.value(false));
when(mockProcessCameraProvider.bindToLifecycle(
mockCameraSelector, <UseCase>[camera.mockImageAnalysis]))
when(mockProcessCameraProvider
.bindToLifecycle(mockCameraSelector, <UseCase>[mockImageAnalysis]))
.thenAnswer((_) async => mockCamera);
when(mockCamera.getCameraInfo()).thenAnswer((_) async => mockCameraInfo);
when(mockCameraInfo.getCameraState())
Expand All @@ -1113,12 +1129,8 @@ void main() {

// Test ImageAnalysis use case is bound to ProcessCameraProvider.
final Analyzer capturedAnalyzer =
verify(camera.mockImageAnalysis.setAnalyzer(captureAny)).captured.single
verify(mockImageAnalysis.setAnalyzer(captureAny)).captured.single
as Analyzer;
await untilCalled(
mockProcessCameraProvider.isBound(camera.mockImageAnalysis));
await untilCalled(mockProcessCameraProvider.bindToLifecycle(
mockCameraSelector, <UseCase>[camera.mockImageAnalysis]));

await capturedAnalyzer.analyze(mockImageProxy);
final CameraImageData imageData = await imageDataCompleter.future;
Expand All @@ -1132,9 +1144,6 @@ void main() {
expect(imageData.height, equals(imageHeight));
expect(imageData.width, equals(imageWidth));

// Verify camera and cameraInfo were properly updated.
expect(camera.camera, equals(mockCamera));
expect(camera.cameraInfo, equals(mockCameraInfo));
await onStreamedFrameAvailableSubscription.cancel();
});

Expand All @@ -1147,26 +1156,19 @@ void main() {
final ProcessCameraProvider mockProcessCameraProvider =
MockProcessCameraProvider();
final CameraSelector mockCameraSelector = MockCameraSelector();
final Camera mockCamera = MockCamera();
final MockImageAnalysis mockImageAnalysis = MockImageAnalysis();

camera.processCameraProvider = mockProcessCameraProvider;
camera.cameraSelector = mockCameraSelector;

when(mockProcessCameraProvider.bindToLifecycle(
mockCameraSelector, <UseCase>[camera.mockImageAnalysis]))
.thenAnswer((_) async => mockCamera);
when(mockCamera.getCameraInfo()).thenAnswer((_) async => MockCameraInfo());
camera.imageAnalysis = mockImageAnalysis;

final StreamSubscription<CameraImageData> imageStreamSubscription = camera
.onStreamedFrameAvailable(cameraId)
.listen((CameraImageData data) {});

when(mockProcessCameraProvider.isBound(camera.mockImageAnalysis))
.thenAnswer((_) async => Future<bool>.value(true));

await imageStreamSubscription.cancel();

verify(camera.mockImageAnalysis.clearAnalyzer());
verify(mockImageAnalysis.clearAnalyzer());
});
}

Expand All @@ -1185,7 +1187,7 @@ class FakeAndroidCameraCameraX extends AndroidCameraCameraX {
final MockCameraSelector mockFrontCameraSelector = MockCameraSelector();
final MockRecorder testRecorder = MockRecorder();
final MockVideoCapture testVideoCapture = MockVideoCapture();
final MockImageAnalysis mockImageAnalysis = MockImageAnalysis();
final MockImageAnalysis testImageAnalysis = MockImageAnalysis();

@override
Future<void> requestCameraPermissions(bool enableAudio) async {
Expand Down Expand Up @@ -1232,6 +1234,6 @@ class FakeAndroidCameraCameraX extends AndroidCameraCameraX {

@override
ImageAnalysis createImageAnalysis() {
return mockImageAnalysis;
return testImageAnalysis;
}
}