Skip to content

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
Dec 6, 2023
Merged

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ff82bc5
pointer interceptor platform implementations
LouiseHsu Nov 28, 2023
c9f7f71
pubspec yaml edits
LouiseHsu Nov 29, 2023
20d7441
remove publish to
LouiseHsu Nov 30, 2023
e55005e
add platform implementations from app facing package
LouiseHsu Nov 30, 2023
c020e19
pubspec
LouiseHsu Nov 30, 2023
91a5857
replace path dependencies
LouiseHsu Nov 30, 2023
9a9e3cf
loosen versioning constraints
LouiseHsu Nov 30, 2023
c8c4413
add authors file
LouiseHsu Dec 1, 2023
596e7c9
pubspec
LouiseHsu Dec 1, 2023
4867f1b
pubspec?
LouiseHsu Dec 1, 2023
e72057e
pr changes
LouiseHsu Dec 1, 2023
03a35a3
fix test
LouiseHsu Dec 1, 2023
9977f6a
add back authors file
LouiseHsu Dec 1, 2023
bc32635
fix authors file
LouiseHsu Dec 4, 2023
10acb61
pr updates
LouiseHsu Dec 4, 2023
ba4bc21
fix tests
LouiseHsu Dec 4, 2023
477c30f
update pubspec
LouiseHsu Dec 5, 2023
2b97d04
fix web tests
LouiseHsu Dec 5, 2023
30d68ff
actually fix tests
LouiseHsu Dec 5, 2023
dae7b4d
pubspec and formatting.............
LouiseHsu Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pr updates
  • Loading branch information
@LouiseHsu
LouiseHsu committed Dec 4, 2023
commit 10acb611594a94c767731934612c6b4e07bb26e1
2 changes: 0 additions & 2 deletions packages/pointer_interceptor/pointer_interceptor_ios/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ dependencies:
cupertino_icons: ^1.0.2
flutter:
sdk: flutter
pointer_interceptor:
path: ../../pointer_interceptor
pointer_interceptor_platform_interface: ^0.10.0

dev_dependencies:
Expand Down
27 changes: 12 additions & 15 deletions packages/pointer_interceptor/pointer_interceptor_web/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'dart:html' as html;
import 'dart:ui_web' as ui_web;

import 'package:flutter/material.dart';
import 'package:pointer_interceptor/pointer_interceptor.dart';
import 'package:pointer_interceptor_platform_interface/pointer_interceptor_platform_interface.dart';

const String _htmlElementViewType = '_htmlElementViewType';
const double _videoWidth = 640;
Expand Down Expand Up @@ -86,7 +86,7 @@ class _MyHomePageState extends State<MyHomePage> {
appBar: AppBar(
title: const Text('PointerInterceptor demo'),
actions: <Widget>[
PointerInterceptor(
PointerInterceptorPlatform.instance.buildWidget(
// debug: true,
child: IconButton(
icon: const Icon(Icons.add_alert),
Expand Down Expand Up @@ -129,18 +129,15 @@ class _MyHomePageState extends State<MyHomePage> {
_clickedOn('transparent-button');
},
),
PointerInterceptor(
intercepting: false,
child: ElevatedButton(
key: const Key('wrapped-transparent-button'),
child:
const Text('Never calls onPressed transparent'),
onPressed: () {
_clickedOn('wrapped-transparent-button');
},
),
ElevatedButton(
key: const Key('wrapped-transparent-button'),
child:
const Text('Never calls onPressed transparent'),
onPressed: () {
_clickedOn('wrapped-transparent-button');
},
),
PointerInterceptor(
PointerInterceptorPlatform.instance.buildWidget(
child: ElevatedButton(
key: const Key('clickable-button'),
child: const Text('Works As Expected'),
Expand All @@ -160,7 +157,7 @@ class _MyHomePageState extends State<MyHomePage> {
floatingActionButton: Row(
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
PointerInterceptor(
PointerInterceptorPlatform.instance.buildWidget(
// debug: true,
child: FloatingActionButton(
child: const Icon(Icons.navigation),
Expand All @@ -172,7 +169,7 @@ class _MyHomePageState extends State<MyHomePage> {
],
),
drawer: Drawer(
child: PointerInterceptor(
child: PointerInterceptorPlatform.instance.buildWidget(
// debug: true, // Enable this to "see" the interceptor covering the column.
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
Expand Down
4 changes: 1 addition & 3 deletions packages/pointer_interceptor/pointer_interceptor_web/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ dependencies:
cupertino_icons: ^1.0.2
flutter:
sdk: flutter
pointer_interceptor:
path: ../../pointer_interceptor
pointer_interceptor_platform_interface: ^0.10.0

dev_dependencies:
flutter_lints: ^2.0.0
flutter_test:
sdk: flutter
integration_test:
Expand Down