Skip to content

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
Dec 6, 2023
Merged

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ff82bc5
pointer interceptor platform implementations
LouiseHsu Nov 28, 2023
c9f7f71
pubspec yaml edits
LouiseHsu Nov 29, 2023
20d7441
remove publish to
LouiseHsu Nov 30, 2023
e55005e
add platform implementations from app facing package
LouiseHsu Nov 30, 2023
c020e19
pubspec
LouiseHsu Nov 30, 2023
91a5857
replace path dependencies
LouiseHsu Nov 30, 2023
9a9e3cf
loosen versioning constraints
LouiseHsu Nov 30, 2023
c8c4413
add authors file
LouiseHsu Dec 1, 2023
596e7c9
pubspec
LouiseHsu Dec 1, 2023
4867f1b
pubspec?
LouiseHsu Dec 1, 2023
e72057e
pr changes
LouiseHsu Dec 1, 2023
03a35a3
fix test
LouiseHsu Dec 1, 2023
9977f6a
add back authors file
LouiseHsu Dec 1, 2023
bc32635
fix authors file
LouiseHsu Dec 4, 2023
10acb61
pr updates
LouiseHsu Dec 4, 2023
ba4bc21
fix tests
LouiseHsu Dec 4, 2023
477c30f
update pubspec
LouiseHsu Dec 5, 2023
2b97d04
fix web tests
LouiseHsu Dec 5, 2023
30d68ff
actually fix tests
LouiseHsu Dec 5, 2023
dae7b4d
pubspec and formatting.............
LouiseHsu Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@LouiseHsu
LouiseHsu committed Dec 4, 2023
commit ba4bc21cedb47f43a353e4b79caca5a89f596f85
2 changes: 2 additions & 0 deletions packages/pointer_interceptor/pointer_interceptor_ios/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ dependencies:
cupertino_icons: ^1.0.2
flutter:
sdk: flutter
pointer_interceptor:
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

Copy link
Contributor Author

@LouiseHsu LouiseHsu Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think I can remove this - the integration tests fail because the swift tests require the pointer_interceptor package.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the dependency on the Swift side that's specific to the app-facing package?

Copy link
Contributor Author

@LouiseHsu LouiseHsu Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it just needs a dependency on pointer_interceptor_ios at least. Ill change it.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed that it didn't have one. The example should definitely depend on the platform it's an example for.

path: ../../pointer_interceptor
pointer_interceptor_platform_interface: ^0.10.0

dev_dependencies:
Expand Down
8 changes: 0 additions & 8 deletions packages/pointer_interceptor/pointer_interceptor_web/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,6 @@ class _MyHomePageState extends State<MyHomePage> {
_clickedOn('transparent-button');
},
),
ElevatedButton(
key: const Key('wrapped-transparent-button'),
child:
const Text('Never calls onPressed transparent'),
onPressed: () {
_clickedOn('wrapped-transparent-button');
},
),
PointerInterceptorPlatform.instance.buildWidget(
child: ElevatedButton(
key: const Key('clickable-button'),
Expand Down