Skip to content

[google_maps_flutter] Add support for version 8 of the iOS SDK #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Nov 30, 2023
Merged

[google_maps_flutter] Add support for version 8 of the iOS SDK #5528

auto-submit merged 8 commits into from
Nov 30, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Nov 30, 2023

  • Increases the max allowed SDK version to 8.x
  • Adds a new iOS 14 example app, per the documented test structure/plan
  • Moves recently added XCUITests to the iOS 11 example app, where they should have been (per doc linked above). I missed this when reviewing the addition, and noticed that it was incorrectly in the iOS 13 example while duplicating the iOS 13 example for the iOS 14 version.

Fixes flutter/flutter#138972

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g changed the title [google_maps_flutter] Add support version 8 of the iOS SDK [google_maps_flutter] Add support for version 8 of the iOS SDK Nov 30, 2023
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Nov 30, 2023

It's probably easiest to review this as individual commits; the big commit called "Add iOS 14" is just an exact copy of example/ios13 to example/ios4 so shouldn't need detailed review.

jmagman
jmagman approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-listing flutter/flutter#86820 and #3757

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Nov 30, 2023

I hit some deprecation warning failures in CI that I didn't find locally, and it turns out that it's because locally I only resolved to 8.2 (presumably for cache reasons), but 8.3 added a new API and deprecated the ones it replaced. If we have OOB failures from that happening in the future we could restrict the range in the podspec to only allow minor versions we have tested, rather than just major ones, but AFAIK it's never hit us before so for now I'll err on the side of keeping a lenient range.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 30, 2023
@auto-submit auto-submit bot merged commit eeecbd4 into flutter:main Nov 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
eeecbd4 [google_maps_flutter] Add support for version 8 of the iOS SDK (
9996c51 
flutter/packages#5528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
eeecbd4 [google_maps_flutter] Add support for version 8 of the iOS SDK (
c2546c8 
flutter/packages#5528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 4, 2023
@engine-flutter-autoroll
eeecbd4 [google_maps_flutter] Add support for version 8 of the iOS SDK (
d17f172 
flutter/packages#5528)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 4, 2023
@engine-flutter-autoroll
Roll Packages from bc72d15 to 5d9874f (9 revisions) (#139480)
df88e3a 
flutter/packages@bc72d15...5d9874f

2023-12-02 [email protected] Roll Flutter from 918e336 to d861ce4 (29 revisions) (flutter/packages#5542)
2023-12-02 [email protected] [gsi_web] Do not initialize CodeClient if scopes are empty. (flutter/packages#5537)
2023-12-01 [email protected] Reenable macOS 13 tests (flutter/packages#5494)
2023-12-01 [email protected] [flutter_image] Adopt code excerpts in README (flutter/packages#5498)
2023-11-30 [email protected] [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter/packages#5520)
2023-11-30 [email protected] [google_maps_flutter] Add support for version 8 of the iOS SDK (flutter/packages#5528)
2023-11-30 [email protected] [pointer_interceptor] Re-land: Add platform interface (flutter/packages#5525)
2023-11-30 [email protected] [google_sign_in] Add server auth code retrieval to gis_client (flutter/packages#5358)
2023-11-30 [email protected] Roll Flutter from 5e5b529 to 918e336 (14 revisions) (flutter/packages#5526)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@arthurmonteiroalvesmelo
Copy link

arthurmonteiroalvesmelo commented Jan 2, 2024

Hey @stuartmorgan

in file (packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/README.md)

The actual text is:

## Versions

This example requires iOS 13, so will select a 7.x GoogleMaps SDK version.

But, the right is:

## Versions

This example requires iOS 14, so will select a 8.x GoogleMaps SDK version.

right?

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jan 2, 2024

Yes, that's a copy/paste mistake.

@stuartmorgan-g stuartmorgan-g deleted the maps-ios-v-8 branch January 2, 2024 20:25
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Add support for iOS Google Maps SDK 8.x

3 participants

@stuartmorgan-g @arthurmonteiroalvesmelo @jmagman