Skip to content

[google_maps_flutter] Add support for version 8 of the iOS SDK #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 8 commits into from
Nov 30, 2023
Merged

[google_maps_flutter] Add support for version 8 of the iOS SDK #5528

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7bb3acc
Move XCUITests to ios11
stuartmorgan-g Nov 30, 2023
28876fa
Add iOS 14
stuartmorgan-g Nov 30, 2023
1d9c0db
Set new example to iOS 14
stuartmorgan-g Nov 30, 2023
4d21f0c
Add SDK 8 support
stuartmorgan-g Nov 30, 2023
f3bf8aa
Version bump
stuartmorgan-g Nov 30, 2023
2178d7f
format
stuartmorgan-g Nov 30, 2023
da14006
Ignore deprecation
stuartmorgan-g Nov 30, 2023
db1c509
Suppress deprecation in test as well
stuartmorgan-g Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore deprecation
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Nov 30, 2023
commit da1400628f214630deed3f45e94a9789da8655ee
7 changes: 7 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,18 @@ - (instancetype)initWithFrame:(CGRect)frame
}
}

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// TODO(stuartmorgan): Switch to initWithOptions: once versions older than
// iOS 14 are no longer supported by the plugin, or there is a specific need
// for its functionality. Since it involves a newly-added class, call it
// dynamically is more trouble than it is currently worth.
if (mapID && [GMSMapView respondsToSelector:@selector(mapWithFrame:mapID:camera:)]) {
mapView = [GMSMapView mapWithFrame:frame mapID:mapID camera:camera];
} else {
mapView = [GMSMapView mapWithFrame:frame camera:camera];
}
#pragma clang diagnostic pop

return [self initWithMapView:mapView viewIdentifier:viewId arguments:args registrar:registrar];
}
Expand Down