Skip to content

[pigeon] Use dart:io output inheritance for tooling #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Dec 6, 2023
Merged

[pigeon] Use dart:io output inheritance for tooling #5536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/pigeon/tool/shared/generation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,5 +246,6 @@ Future<int> formatAllFiles({required String repositoryRoot}) {
'--packages=pigeon',
],
workingDirectory: repositoryRoot,
streamOutput: false,
logFailure: true);
}
16 changes: 4 additions & 12 deletions packages/pigeon/tool/shared/process_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,19 @@
// found in the LICENSE file.

import 'dart:async';
import 'dart:io' show Process, stderr, stdout;

Future<Process> _streamOutput(Future<Process> processFuture) async {
final Process process = await processFuture;
await Future.wait(<Future<Object?>>[
stdout.addStream(process.stdout),
stderr.addStream(process.stderr),
]);
return process;
}
import 'dart:io' show Process, ProcessStartMode, stderr, stdout;

Future<int> runProcess(String command, List<String> arguments,
{String? workingDirectory,
bool streamOutput = true,
bool logFailure = false}) async {
final Future<Process> future = Process.start(
final Process process = await Process.start(
command,
arguments,
workingDirectory: workingDirectory,
mode:
streamOutput ? ProcessStartMode.inheritStdio : ProcessStartMode.normal,
);
final Process process = await (streamOutput ? _streamOutput(future) : future);
final int exitCode = await process.exitCode;
if (exitCode != 0 && logFailure) {
// ignore: avoid_print
Expand Down