Skip to content

[camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Mar 15, 2024
Merged

[camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll #6318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d024148
try fix failing tests
bparrishMines Mar 13, 2024
e51bb0c
main bump
bparrishMines Mar 13, 2024
38fec40
skip test for later debugging
bparrishMines Mar 14, 2024
f163eba
explain
bparrishMines Mar 14, 2024
d6db86c
Merge branch 'main' of github.com:flutter/packages into manual_roll
bparrishMines Mar 14, 2024
3af6ba7
lower version and fix other test
bparrishMines Mar 14, 2024
efd3de3
skip another test
bparrishMines Mar 14, 2024
ff33523
skip the other tests
bparrishMines Mar 14, 2024
0dd56f5
Merge branch 'main' of github.com:flutter/packages into manual_roll
bparrishMines Mar 14, 2024
63beeec
skip from root
bparrishMines Mar 14, 2024
ff4fc7c
add error issue
bparrishMines Mar 14, 2024
8e574b6
move exclude to config file
bparrishMines Mar 15, 2024
d45618c
fix lint
bparrishMines Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip from root
  • Loading branch information
@bparrishMines
bparrishMines committed Mar 14, 2024
commit 63beeec5c26ec36def65982bc6a30c70b29a7edc
9 changes: 6 additions & 3 deletions ...es/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import 'package:integration_test/integration_test.dart';

import 'src/maps_controller.dart' as maps_controller;
import 'src/maps_inspector.dart' as maps_inspector;
import 'src/shared.dart';
import 'src/tiles_inspector.dart' as tiles_inspector;

/// Recombine all test files in `src` into a single test app.
Expand All @@ -15,7 +16,9 @@ import 'src/tiles_inspector.dart' as tiles_inspector;
void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();

maps_controller.runTests();
maps_inspector.runTests();
tiles_inspector.runTests();
if (!isWeb) {
maps_controller.runTests();
maps_inspector.runTests();
tiles_inspector.runTests();
}
}
89 changes: 31 additions & 58 deletions ...google_maps_flutter/google_maps_flutter/example/integration_test/src/maps_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,7 @@ void runTests() {
expect(secondVisibleRegion.contains(newCenter), isTrue);
},
// TODO(stuartmorgan): Re-enable; see https://github.com/flutter/flutter/issues/139825
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isIOS || isWeb);
skip: isIOS);

testWidgets('testSetMapStyle valid Json String', (WidgetTester tester) async {
final Key key = GlobalKey();
Expand All @@ -163,10 +161,7 @@ void runTests() {
const String mapStyle =
'[{"elementType":"geometry","stylers":[{"color":"#242f3e"}]}]';
await controller.setMapStyle(mapStyle);
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});

testWidgets('testSetMapStyle invalid Json String',
(WidgetTester tester) async {
Expand All @@ -192,10 +187,7 @@ void runTests() {
} on MapStyleException catch (e) {
expect(e.cause, isNotNull);
}
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});

testWidgets('testSetMapStyle null string', (WidgetTester tester) async {
final Key key = GlobalKey();
Expand All @@ -215,10 +207,7 @@ void runTests() {
final GoogleMapController controller = await controllerCompleter.future;

await controller.setMapStyle(null);
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});

testWidgets('testGetLatLng', (WidgetTester tester) async {
final Key key = GlobalKey();
Expand Down Expand Up @@ -252,10 +241,7 @@ void runTests() {
);

expect(topLeft, northWest);
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});

testWidgets('testGetZoomLevel', (WidgetTester tester) async {
final Key key = GlobalKey();
Expand Down Expand Up @@ -289,9 +275,7 @@ void runTests() {
expect(zoom, equals(7));
},
// TODO(stuartmorgan): Re-enable; see https://github.com/flutter/flutter/issues/139825
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isIOS || isWeb);
skip: isIOS);

testWidgets('testScreenCoordinate', (WidgetTester tester) async {
final Key key = GlobalKey();
Expand Down Expand Up @@ -326,9 +310,7 @@ void runTests() {
expect(topLeft, const ScreenCoordinate(x: 0, y: 0));
},
// TODO(stuartmorgan): Re-enable; see https://github.com/flutter/flutter/issues/139825
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isIOS || isWeb);
skip: isIOS);

testWidgets('testResizeWidget', (WidgetTester tester) async {
final Completer<GoogleMapController> controllerCompleter =
Expand Down Expand Up @@ -369,10 +351,7 @@ void runTests() {
final LatLngBounds bounds1 = await controller.getVisibleRegion();
final LatLngBounds bounds2 = await controller.getVisibleRegion();
expect(bounds1, bounds2);
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});

testWidgets('testToggleInfoWindow', (WidgetTester tester) async {
const Marker marker = Marker(
Expand Down Expand Up @@ -420,10 +399,7 @@ void runTests() {
await controller.hideMarkerInfoWindow(marker.markerId);
iwVisibleStatus = await controller.isMarkerInfoWindowShown(marker.markerId);
expect(iwVisibleStatus, false);
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});

testWidgets('testTakeSnapshot', (WidgetTester tester) async {
final Completer<GoogleMapController> controllerCompleter =
Expand All @@ -449,29 +425,29 @@ void runTests() {
// https://github.com/flutter/flutter/issues/139825
skip: isAndroid || isWeb || isIOS);

testWidgets('testCloudMapId', (WidgetTester tester) async {
final Completer<int> mapIdCompleter = Completer<int>();
final Key key = GlobalKey();
testWidgets(
'testCloudMapId',
(WidgetTester tester) async {
final Completer<int> mapIdCompleter = Completer<int>();
final Key key = GlobalKey();

await pumpMap(
tester,
GoogleMap(
key: key,
initialCameraPosition: kInitialCameraPosition,
onMapCreated: (GoogleMapController controller) {
mapIdCompleter.complete(controller.mapId);
},
cloudMapId: kCloudMapId,
),
);
await tester.pumpAndSettle();
await pumpMap(
tester,
GoogleMap(
key: key,
initialCameraPosition: kInitialCameraPosition,
onMapCreated: (GoogleMapController controller) {
mapIdCompleter.complete(controller.mapId);
},
cloudMapId: kCloudMapId,
),
);
await tester.pumpAndSettle();

// Await mapIdCompleter to finish to make sure map can be created with cloudMapId
await mapIdCompleter.future;
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
// Await mapIdCompleter to finish to make sure map can be created with cloudMapId
await mapIdCompleter.future;
},
);

testWidgets('getStyleError reports last error', (WidgetTester tester) async {
final Key key = GlobalKey();
Expand All @@ -493,10 +469,7 @@ void runTests() {
final GoogleMapController controller = await controllerCompleter.future;
final String? error = await controller.getStyleError();
expect(error, isNotNull);
},
// TODO(bparrishMines): This is failing due to an error being thrown after completion.
// See https://github.com/flutter/flutter/issues/145149
skip: isWeb);
});
}

/// Repeatedly checks an asynchronous value against a test condition.
Expand Down