Skip to content

[camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Mar 15, 2024
Merged

[camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll #6318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d024148
try fix failing tests
bparrishMines Mar 13, 2024
e51bb0c
main bump
bparrishMines Mar 13, 2024
38fec40
skip test for later debugging
bparrishMines Mar 14, 2024
f163eba
explain
bparrishMines Mar 14, 2024
d6db86c
Merge branch 'main' of github.com:flutter/packages into manual_roll
bparrishMines Mar 14, 2024
3af6ba7
lower version and fix other test
bparrishMines Mar 14, 2024
efd3de3
skip another test
bparrishMines Mar 14, 2024
ff33523
skip the other tests
bparrishMines Mar 14, 2024
0dd56f5
Merge branch 'main' of github.com:flutter/packages into manual_roll
bparrishMines Mar 14, 2024
63beeec
skip from root
bparrishMines Mar 14, 2024
ff4fc7c
add error issue
bparrishMines Mar 14, 2024
8e574b6
move exclude to config file
bparrishMines Mar 15, 2024
d45618c
fix lint
bparrishMines Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
try fix failing tests
  • Loading branch information
@bparrishMines
bparrishMines committed Mar 13, 2024
commit d024148d52d91106302df3e7b6fefce36262d7b7
21 changes: 9 additions & 12 deletions packages/camera/camera_web/example/integration_test/camera_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2384,10 +2384,9 @@ void main() {

testWidgets('onCameraResolutionChanged emits an empty stream',
(WidgetTester tester) async {
expect(
CameraPlatform.instance.onCameraResolutionChanged(cameraId),
emits(isEmpty),
);
final Stream<CameraResolutionChangedEvent> stream =
CameraPlatform.instance.onCameraResolutionChanged(cameraId);
expect(await stream.isEmpty, isTrue);
});

testWidgets(
Expand Down Expand Up @@ -2968,20 +2967,18 @@ void main() {
(WidgetTester tester) async {
when(() => window.screen).thenReturn(null);

expect(
CameraPlatform.instance.onDeviceOrientationChanged(),
emits(isEmpty),
);
final Stream<DeviceOrientationChangedEvent> stream =
CameraPlatform.instance.onDeviceOrientationChanged();
expect(await stream.isEmpty, isTrue);
});

testWidgets('when screen orientation is not supported',
(WidgetTester tester) async {
when(() => screen.orientation).thenReturn(null);

expect(
CameraPlatform.instance.onDeviceOrientationChanged(),
emits(isEmpty),
);
final Stream<DeviceOrientationChangedEvent> stream =
CameraPlatform.instance.onDeviceOrientationChanged();
expect(await stream.isEmpty, isTrue);
});
});

Expand Down
1 change: 1 addition & 0 deletions ...google_maps_flutter/google_maps_flutter/example/integration_test/src/maps_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ void runTests() {

final LatLngBounds secondVisibleRegion =
await mapController.getVisibleRegion();
await tester.pumpAndSettle();

expect(secondVisibleRegion, isNot(zeroLatLngBounds));

Expand Down
1 change: 1 addition & 0 deletions ...google_maps_flutter/google_maps_flutter_web/example/integration_test/projection_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ void main() {
12,
),
);
await tester.pump();

final LatLng coords = await controller.getLatLng(
ScreenCoordinate(x: size.width ~/ 2, y: size.height ~/ 2),
Expand Down