Skip to content

[google_maps_flutter] Fix ios tile overlay not loading when dealing with wide gamut images #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouiseHsu merged 10 commits into from
Mar 27, 2024
Merged

[google_maps_flutter] Fix ios tile overlay not loading when dealing with wide gamut images #6377

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2290472
remove extra proj files
LouiseHsu Mar 22, 2024
72b7252
Merge branch 'main' into fix-wide-gamut-issue-google-maps
LouiseHsu Mar 22, 2024
c80245b
delicious formatting
LouiseHsu Mar 22, 2024
372d30d
Merge branch 'fix-wide-gamut-issue-google-maps' of github.com:LouiseH…
LouiseHsu Mar 22, 2024
5d95c7d
add test
LouiseHsu Mar 26, 2024
54ffeef
missed asset file oopsies
LouiseHsu Mar 26, 2024
efb9f4d
pr updates, removed lingering RunnerUITest references
LouiseHsu Mar 27, 2024
5912d94
test name
LouiseHsu Mar 27, 2024
d889ab9
pubspec, changelog, formatting
LouiseHsu Mar 27, 2024
3a7a54e
warning
LouiseHsu Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
warning
  • Loading branch information
@LouiseHsu
LouiseHsu committed Mar 27, 2024
commit 3a7a54eb50d2e440365c60169f730d694eeacdff
1 change: 0 additions & 1 deletion ...ogle_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ - (void)testHandleResultTileDownsamplesWideGamutImages {
UIImage *downsampledImage = [controller handleResultTile:wideGamutImage];

CGImageRef imageRef = downsampledImage.CGImage;
CGBitmapInfo bitmapInfo = CGImageGetBitmapInfo(imageRef);
size_t bitsPerComponent = CGImageGetBitsPerComponent(imageRef);

// non wide gamut images use 8 bit format
Expand Down