Skip to content

[google_maps_flutter] Fix ios tile overlay not loading when dealing with wide gamut images #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouiseHsu merged 10 commits into from
Mar 27, 2024
Merged

[google_maps_flutter] Fix ios tile overlay not loading when dealing with wide gamut images #6377

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2290472
remove extra proj files
LouiseHsu Mar 22, 2024
72b7252
Merge branch 'main' into fix-wide-gamut-issue-google-maps
LouiseHsu Mar 22, 2024
c80245b
delicious formatting
LouiseHsu Mar 22, 2024
372d30d
Merge branch 'fix-wide-gamut-issue-google-maps' of github.com:LouiseH…
LouiseHsu Mar 22, 2024
5d95c7d
add test
LouiseHsu Mar 26, 2024
54ffeef
missed asset file oopsies
LouiseHsu Mar 26, 2024
efb9f4d
pr updates, removed lingering RunnerUITest references
LouiseHsu Mar 27, 2024
5912d94
test name
LouiseHsu Mar 27, 2024
d889ab9
pubspec, changelog, formatting
LouiseHsu Mar 27, 2024
3a7a54e
warning
LouiseHsu Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delicious formatting
  • Loading branch information
@LouiseHsu
LouiseHsu committed Mar 22, 2024
commit c80245b2a31f38e6df53d6c58d0c5e847da04196
97 changes: 50 additions & 47 deletions ...ogle_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTGoogleMapTileOverlayController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,53 +123,56 @@ - (void)requestTileForX:(NSUInteger)x
zoom:(NSUInteger)zoom
receiver:(id<GMSTileReceiver>)receiver {
dispatch_async(dispatch_get_main_queue(), ^{
[self.methodChannel
invokeMethod:@"tileOverlay#getTile"
arguments:@{
@"tileOverlayId" : self.tileOverlayIdentifier,
@"x" : @(x),
@"y" : @(y),
@"zoom" : @(zoom)
}
result:^(id _Nullable result) {
UIImage *tileImage;
if ([result isKindOfClass:[NSDictionary class]]) {
FlutterStandardTypedData *typedData = (FlutterStandardTypedData *)result[@"data"];
if (typedData == nil) {
tileImage = kGMSTileLayerNoTile;
} else {
tileImage = [UIImage imageWithData:typedData.data];
CGImageRef imageRef = tileImage.CGImage;
CGBitmapInfo bitmapInfo = CGImageGetBitmapInfo(imageRef);
bool isFloat = (bitmapInfo && kCGBitmapFloatComponents);
size_t bitsPerComponent = CGImageGetBitsPerComponent(imageRef);

// Engine use f16 pixel format for wide gamut images
// If it is wide gamut, we want to downsample it
if (isFloat & (bitsPerComponent == 16)) {
CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
CGContextRef context = CGBitmapContextCreate(nil, tileImage.size.width, tileImage.size.height, 8, 0, colorSpace, kCGImageAlphaPremultipliedLast);
CGContextDrawImage(context, CGRectMake(0, 0, tileImage.size.width, tileImage.size.height), tileImage.CGImage);
CGImageRef image = CGBitmapContextCreateImage(context);
tileImage = [UIImage imageWithCGImage:image];
CGImageRelease(image);
CGContextRelease(context);
CGColorSpaceRelease(colorSpace);
}
}
} else {
if ([result isKindOfClass:[FlutterError class]]) {
FlutterError *error = (FlutterError *)result;
NSLog(@"Can't get tile: errorCode = %@, errorMessage = %@, details = %@",
[error code], [error message], [error details]);
}
if ([result isKindOfClass:[FlutterMethodNotImplemented class]]) {
NSLog(@"Can't get tile: notImplemented");
}
tileImage = kGMSTileLayerNoTile;
}
[receiver receiveTileWithX:x y:y zoom:zoom image:tileImage];
}];
[self.methodChannel invokeMethod:@"tileOverlay#getTile"
arguments:@{
@"tileOverlayId" : self.tileOverlayIdentifier,
@"x" : @(x),
@"y" : @(y),
@"zoom" : @(zoom)
}
result:^(id _Nullable result) {
UIImage *tileImage;
if ([result isKindOfClass:[NSDictionary class]]) {
FlutterStandardTypedData *typedData = (FlutterStandardTypedData *)result[@"data"];
if (typedData == nil) {
tileImage = kGMSTileLayerNoTile;
} else {
tileImage = [UIImage imageWithData:typedData.data];
CGImageRef imageRef = tileImage.CGImage;
CGBitmapInfo bitmapInfo = CGImageGetBitmapInfo(imageRef);
bool isFloat = (bitmapInfo && kCGBitmapFloatComponents);
size_t bitsPerComponent = CGImageGetBitsPerComponent(imageRef);

// Engine use f16 pixel format for wide gamut images
// If it is wide gamut, we want to downsample it
if (isFloat & (bitsPerComponent == 16)) {
CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
CGContextRef context =
CGBitmapContextCreate(nil, tileImage.size.width, tileImage.size.height, 8, 0,
colorSpace, kCGImageAlphaPremultipliedLast);
CGContextDrawImage(context,
CGRectMake(0, 0, tileImage.size.width, tileImage.size.height),
tileImage.CGImage);
CGImageRef image = CGBitmapContextCreateImage(context);
tileImage = [UIImage imageWithCGImage:image];
CGImageRelease(image);
CGContextRelease(context);
CGColorSpaceRelease(colorSpace);
}
}
} else {
if ([result isKindOfClass:[FlutterError class]]) {
FlutterError *error = (FlutterError *)result;
NSLog(@"Can't get tile: errorCode = %@, errorMessage = %@, details = %@",
[error code], [error message], [error details]);
}
if ([result isKindOfClass:[FlutterMethodNotImplemented class]]) {
NSLog(@"Can't get tile: notImplemented");
}
tileImage = kGMSTileLayerNoTile;
}
[receiver receiveTileWithX:x y:y zoom:zoom image:tileImage];
}];
});
}

Expand Down