Skip to content

[quick_actions_android] Switch to Compat version of ShortcutManager to support Google surfaces #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
May 10, 2024
Merged

[quick_actions_android] Switch to Compat version of ShortcutManager to support Google surfaces #6638

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bf35ba
do the conversion
May 2, 2024
527f1aa
Merge branch 'main' into quick_actions_google_surfaces
gmackall May 7, 2024
b8c9c7d
just delete the shortcutmanager mocking in tests? it works?
May 7, 2024
2fe7420
pubspec+changelog
May 7, 2024
ff8c78a
format
May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
just delete the shortcutmanager mocking in tests? it works?
  • Loading branch information
Gray Mackall committed May 7, 2024
commit b8c9c7d528a5b97d10e7ba22d97388459ffeecb9
5 changes: 0 additions & 5 deletions ...tions_android/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import android.app.Activity;
import android.content.Context;
import android.content.Intent;
import android.content.pm.ShortcutManager;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import io.flutter.embedding.engine.plugins.FlutterPlugin.FlutterPluginBinding;
Expand Down Expand Up @@ -76,8 +75,6 @@ public void onAttachedToActivity_buildVersionSupported_invokesLaunchMethod()
when(mockActivityPluginBinding.getActivity()).thenReturn(mockMainActivity);
final Context mockContext = mock(Context.class);
when(mockMainActivity.getApplicationContext()).thenReturn(mockContext);
final ShortcutManager mockShortcutManager = mock(ShortcutManager.class);
when(mockContext.getSystemService(Context.SHORTCUT_SERVICE)).thenReturn(mockShortcutManager);
plugin.onAttachedToActivity(mockActivityPluginBinding);

// Act
Expand Down Expand Up @@ -118,8 +115,6 @@ public void onNewIntent_buildVersionSupported_invokesLaunchMethod() {
when(mockActivityPluginBinding.getActivity()).thenReturn(mockMainActivity);
final Context mockContext = mock(Context.class);
when(mockMainActivity.getApplicationContext()).thenReturn(mockContext);
final ShortcutManager mockShortcutManager = mock(ShortcutManager.class);
when(mockContext.getSystemService(Context.SHORTCUT_SERVICE)).thenReturn(mockShortcutManager);
plugin.onAttachedToActivity(mockActivityPluginBinding);

// Act
Expand Down