Skip to content

[local_auth] Convert native unit tests to Swift #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
May 22, 2024
Merged

[local_auth] Convert native unit tests to Swift #6779

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6a9e65
[local_auth] Convert native unit tests to Swift
stuartmorgan-g May 20, 2024
f9793de
Review feedback
stuartmorgan-g May 22, 2024
dc799d7
Ignore test files when determining if Swift podpsec entries are required
stuartmorgan-g May 22, 2024
ba09fa4
Recognize darwin/Tests/ as a test path
stuartmorgan-g May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore test files when determining if Swift podpsec entries are required
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 22, 2024
commit dc799d7af7026596fd5ad1a8a57e7eddd0a82203
6 changes: 6 additions & 0 deletions script/tool/lib/src/podspec_check_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,12 @@ class PodspecCheckCommand extends PackageLoopingCommand {
if (relativePath.startsWith('example/')) {
return false;
}
// Ignore test code.
if (relativePath.contains('/Tests/') ||
relativePath.contains('/RunnerTests/') ||
relativePath.contains('/RunnerUITests/')) {
return false;
}
final String filePath = entity.path;
return filePath != iosSwiftPackageManifestPath &&
filePath != darwinSwiftPackageManifestPath &&
Expand Down
25 changes: 25 additions & 0 deletions script/tool/test/podspec_check_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,31 @@ void main() {
));
});

test('does not require the search paths workaround for Swift tests',
() async {
final RepositoryPackage plugin = createFakePlugin(
'plugin1',
packagesDir,
extraFiles: <String>[
'darwin/Tests/SharedTest.swift',
'example/ios/RunnerTests/UnitTest.swift',
'example/ios/RunnerUITests/UITest.swift',
],
);
_writeFakePodspec(plugin, 'ios');

final List<String> output =
await runCapturingPrint(runner, <String>['podspec-check']);

expect(
output,
containsAllInOrder(
<Matcher>[
contains('Ran for 1 package(s)'),
],
));
});

test(
'does not require the search paths workaround for darwin Package.swift',
() async {
Expand Down