Skip to content

[local_auth] Convert native unit tests to Swift #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
May 22, 2024
Merged

[local_auth] Convert native unit tests to Swift #6779

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6a9e65
[local_auth] Convert native unit tests to Swift
stuartmorgan-g May 20, 2024
f9793de
Review feedback
stuartmorgan-g May 22, 2024
dc799d7
Ignore test files when determining if Swift podpsec entries are required
stuartmorgan-g May 22, 2024
ba09fa4
Recognize darwin/Tests/ as a test path
stuartmorgan-g May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review feedback
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 22, 2024
commit f9793deb2d75331ca2f6aed8e7f452001087e89c
20 changes: 7 additions & 13 deletions packages/local_auth/local_auth_darwin/darwin/Tests/FLALocalAuthPluginTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,22 @@ import XCTest
@testable import local_auth_darwin

// Set a long timeout to avoid flake due to slow CI.
let timeout: TimeInterval = 30.0
private let timeout: TimeInterval = 30.0

/// A context factory that returns preset contexts.
class StubAuthContextFactory: NSObject, FLADAuthContextFactory {
final class StubAuthContextFactory: NSObject, FLADAuthContextFactory {
var contexts: [FLADAuthContext]
init(contexts: [FLADAuthContext]) {
self.contexts = contexts
}

func createAuthContext() -> FLADAuthContext {
XCTAssert(self.contexts.count > 0, "Insufficient test contexts provided")
let context = self.contexts.first!
contexts.remove(at: 0)
return context
return self.contexts.removeFirst()
}
}

class StubAuthContext: NSObject, FLADAuthContext {
final class StubAuthContext: NSObject, FLADAuthContext {
/// Whether calls to this stub are expected to be for biometric authentication.
///
/// While this object could be set up to return different values for different policies, in
Expand All @@ -40,7 +38,7 @@ class StubAuthContext: NSObject, FLADAuthContext {
var evaluateError: NSError?

// Overridden as read-write to allow stubbing.
var biometryType: LABiometryType = LABiometryType.none
var biometryType: LABiometryType = .none
var localizedFallbackTitle: String?

func canEvaluatePolicy(_ policy: LAPolicy) throws {
Expand Down Expand Up @@ -75,10 +73,6 @@ class StubAuthContext: NSObject, FLADAuthContext {

class FLALocalAuthPluginTests: XCTestCase {

override func setUp() {
continueAfterFailure = false
}

func testSuccessfullAuthWithBiometrics() throws {
let stubAuthContext = StubAuthContext()
let plugin = FLALocalAuthPlugin(
Expand Down Expand Up @@ -330,7 +324,7 @@ class FLALocalAuthPluginTests: XCTestCase {
contextFactory: StubAuthContextFactory(contexts: [stubAuthContext]))

stubAuthContext.expectBiometrics = true
stubAuthContext.biometryType = LABiometryType.faceID
stubAuthContext.biometryType = .faceID

var error: FlutterError?
let result = plugin.getEnrolledBiometricsWithError(&error)
Expand All @@ -345,7 +339,7 @@ class FLALocalAuthPluginTests: XCTestCase {
contextFactory: StubAuthContextFactory(contexts: [stubAuthContext]))

stubAuthContext.expectBiometrics = true
stubAuthContext.biometryType = LABiometryType.touchID
stubAuthContext.biometryType = .touchID

var error: FlutterError?
let result = plugin.getEnrolledBiometricsWithError(&error)
Expand Down