Skip to content

[rfw][ci] Skip failing rfw golden tests and manual roll #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jun 12, 2024
Merged

[rfw][ci] Skip failing rfw golden tests and manual roll #6915

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f98dc4
skip failing rfw test and manual roll
bparrishMines Jun 12, 2024
f21e45c
move skip
bparrishMines Jun 12, 2024
f696871
skip another golden test
bparrishMines Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move skip
  • Loading branch information
@bparrishMines
bparrishMines committed Jun 12, 2024
commit f21e45cf9a0a5e0e6f989f523670e5a0121e87a7
9 changes: 4 additions & 5 deletions packages/rfw/test/material_widgets_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.material_properties.png'),
skip: !runGoldens,
// TODO(bparrishMines): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/150127
skip: !runGoldens || true,
);

runtime.update(testName, parseLibraryFile('''
Expand All @@ -585,10 +587,7 @@ void main() {

expect(tester.widget<Material>(find.byType(Material)).clipBehavior,
Clip.antiAlias);
},
// TODO(bparrishMines): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/150127
skip: true);
});

testWidgets('Slider properties', (WidgetTester tester) async {
final Runtime runtime = setupRuntime();
Expand Down