Skip to content

[rfw][ci] Skip failing rfw golden tests and manual roll #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jun 12, 2024
Merged

[rfw][ci] Skip failing rfw golden tests and manual roll #6915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f98dc4
skip failing rfw test and manual roll
bparrishMines Jun 12, 2024
f21e45c
move skip
bparrishMines Jun 12, 2024
f696871
skip another golden test
bparrishMines Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14df7be3f9471a97f34e4601fb7710850373ac3b
b1f9d7131c8cc69fd6b0995a44c56a9b835cbd11
8 changes: 6 additions & 2 deletions packages/rfw/test/material_widgets_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ void main() {
await expectLater(
find.byType(MaterialApp),
matchesGoldenFile('goldens/material_test.dropdown.png'),
skip: !runGoldens,
// TODO(bparrishMines): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/150127
skip: !runGoldens || true,
);
// Tap on the second item.
await tester.tap(find.text('bar'));
Expand Down Expand Up @@ -566,7 +568,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.material_properties.png'),
skip: !runGoldens,
// TODO(bparrishMines): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/150127
skip: !runGoldens || true,
);

runtime.update(testName, parseLibraryFile('''
Expand Down