Skip to content

Allow custom blocks to be something other than Column or SizedBox #7859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Oct 21, 2024
Merged

Allow custom blocks to be something other than Column or SizedBox #7859

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3e7045
Add support for custom tag blocks
gspencergoog Oct 11, 2024
21b8275
Bump version
gspencergoog Oct 12, 2024
2144215
Review Changes
gspencergoog Oct 14, 2024
391f89f
Remove new API, update test
gspencergoog Oct 14, 2024
869aa9a
Fix version bump
gspencergoog Oct 14, 2024
e6ed413
Address review comments
gspencergoog Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review Changes
  • Loading branch information
@gspencergoog
gspencergoog committed Oct 21, 2024
commit 214421523232ed4fcdb61a4e39e42e756e2ebd1b
4 changes: 2 additions & 2 deletions packages/flutter_markdown/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class MarkdownBuilder implements md.NodeVisitor {
final MarkdownListItemCrossAxisAlignment listItemCrossAxisAlignment;

/// Collection of custom block tags to be used building block widgets.
final List<String>? customBlockTags;
final List<String> customBlockTags;

/// Called when the user changes selection when [selectable] is set to true.
final MarkdownOnSelectionChangedCallback? onSelectionChanged;
Expand All @@ -182,7 +182,7 @@ class MarkdownBuilder implements md.NodeVisitor {

bool _isBlockTag(String? tag) =>
_kBlockTags.contains(tag) ||
(customBlockTags ?? <String>[]).contains(tag);
customBlockTags.contains(tag);

/// Returns widgets that display the given Markdown nodes.
///
Expand Down