Skip to content

Allow custom blocks to be something other than Column or SizedBox #7859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Oct 21, 2024
Merged

Allow custom blocks to be something other than Column or SizedBox #7859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3e7045
Add support for custom tag blocks
gspencergoog Oct 11, 2024
21b8275
Bump version
gspencergoog Oct 12, 2024
2144215
Review Changes
gspencergoog Oct 14, 2024
391f89f
Remove new API, update test
gspencergoog Oct 14, 2024
869aa9a
Fix version bump
gspencergoog Oct 14, 2024
e6ed413
Address review comments
gspencergoog Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix version bump
  • Loading branch information
@gspencergoog
gspencergoog committed Oct 21, 2024
commit 869aa9a3fc0aaaf7c5fe5b229447a62f6194a94e
2 changes: 1 addition & 1 deletion packages/flutter_markdown/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 0.7.5
## 0.7.4+1

* Makes it so that custom blocks are not limited to being a Column or
SizedBox.
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_markdown/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Markdown renderer for Flutter. Create rich text output,
formatted with simple Markdown tags.
repository: https://github.com/flutter/packages/tree/main/packages/flutter_markdown
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_markdown%22
version: 0.7.4
version: 0.7.4+1

environment:
sdk: ^3.3.0
Expand Down
4 changes: 1 addition & 3 deletions packages/flutter_markdown/test/custom_syntax_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,7 @@ class NoteSyntax extends md.BlockSyntax {

class CustomTagBlockBuilder extends MarkdownElementBuilder {
@override
bool isBlockElement() {
return true;
}
bool isBlockElement() => true;

@override
Widget visitElementAfterWithContext(
Expand Down