-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[camera_avfoundation] Tests backfilling - part 1 #8698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 7 commits into
flutter:main
from
leancodepl:feature/camera-tests-backfilling
Mar 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
73d41b6
Backfill tests for CameraPlugin class
RobertOdrowaz c55ddc6
Extract forwarding method tests to separate PR
RobertOdrowaz ca5ceaa
Use inferred types if possible
RobertOdrowaz 72edba6
Correct formatting
RobertOdrowaz f42a53d
Fix MockFLTCam formatting
RobertOdrowaz c746aa8
Tweak camera tests
RobertOdrowaz be6ff6e
Rename testCreateCamera_assignsCamera to _createsFLTCamSuccessfully
RobertOdrowaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Backfill tests for CameraPlugin class
- Loading branch information
commit 73d41b60682365dc96397e9cdb54978d73b4b5f7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
...es/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import XCTest | ||
|
|
||
| @testable import camera_avfoundation | ||
|
|
||
| final class CameraPluginCreateCameraTests: XCTestCase { | ||
| private func createSutAndMocks() -> ( | ||
RobertOdrowaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| CameraPlugin, MockFLTCameraPermissionManager, MockCaptureSession | ||
| ) { | ||
| let mockPermissionManager = MockFLTCameraPermissionManager() | ||
| let mockCaptureSession = MockCaptureSession() | ||
|
|
||
| let cameraPlugin = CameraPlugin( | ||
| registry: MockFlutterTextureRegistry(), | ||
| messenger: MockFlutterBinaryMessenger(), | ||
| globalAPI: MockGlobalEventApi(), | ||
| deviceDiscoverer: MockCameraDeviceDiscoverer(), | ||
| permissionManager: mockPermissionManager, | ||
| deviceFactory: { _ in MockCaptureDevice() }, | ||
| captureSessionFactory: { mockCaptureSession }, | ||
| captureDeviceInputFactory: MockCaptureDeviceInputFactory() | ||
| ) | ||
|
|
||
| return (cameraPlugin, mockPermissionManager, mockCaptureSession) | ||
| } | ||
|
|
||
| func testCreateCamera_requestsOnlyCameraPermissionWithAudioDisabled() { | ||
| let (cameraPlugin, mockPermissionManager, _) = createSutAndMocks() | ||
| let expectation = expectation(description: "Initialization completed") | ||
|
|
||
| var requestCameraPermissionCalled = false | ||
| mockPermissionManager.requestCameraPermissionStub = { completion in | ||
| requestCameraPermissionCalled = true | ||
| completion?(nil) | ||
| } | ||
| var requestAudioPermissionCalled = false | ||
| mockPermissionManager.requestAudioPermissionStub = { completion in | ||
| requestAudioPermissionCalled = true | ||
| completion?(nil) | ||
| } | ||
|
|
||
| cameraPlugin.createCamera( | ||
| withName: "camera_name", | ||
| settings: FCPPlatformMediaSettings.make( | ||
| with: FCPPlatformResolutionPreset.medium, | ||
| framesPerSecond: nil, | ||
| videoBitrate: nil, | ||
| audioBitrate: nil, | ||
| enableAudio: false | ||
| ) | ||
RobertOdrowaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ) { result, error in | ||
| expectation.fulfill() | ||
| } | ||
|
|
||
| waitForExpectations(timeout: 30, handler: nil) | ||
|
|
||
| XCTAssertTrue(requestCameraPermissionCalled) | ||
| XCTAssertFalse(requestAudioPermissionCalled) | ||
| } | ||
|
|
||
| func testCreateCamera_requestsCameraAndAudioPermissionWithAudioEnabled() { | ||
| let (cameraPlugin, mockPermissionManager, _) = createSutAndMocks() | ||
| let expectation = expectation(description: "Initialization completed") | ||
|
|
||
| var requestCameraPermissionCalled = false | ||
| mockPermissionManager.requestCameraPermissionStub = { completion in | ||
| requestCameraPermissionCalled = true | ||
| completion?(nil) | ||
| } | ||
| var requestAudioPermissionCalled = false | ||
| mockPermissionManager.requestAudioPermissionStub = { completion in | ||
| requestAudioPermissionCalled = true | ||
| completion?(nil) | ||
| } | ||
|
|
||
| cameraPlugin.createCamera( | ||
| withName: "camera_name", | ||
| settings: FCPPlatformMediaSettings.make( | ||
| with: FCPPlatformResolutionPreset.medium, | ||
| framesPerSecond: nil, | ||
| videoBitrate: nil, | ||
| audioBitrate: nil, | ||
| enableAudio: true | ||
| ) | ||
| ) { result, error in | ||
| expectation.fulfill() | ||
| } | ||
|
|
||
| waitForExpectations(timeout: 30, handler: nil) | ||
|
|
||
| XCTAssertTrue(requestCameraPermissionCalled) | ||
| XCTAssertTrue(requestAudioPermissionCalled) | ||
| } | ||
|
|
||
| func testCreateCamera_assignsCamera() { | ||
RobertOdrowaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| let (cameraPlugin, mockPermissionManager, mockCaptureSession) = createSutAndMocks() | ||
| let expectation = expectation(description: "Initialization completed") | ||
|
|
||
| mockPermissionManager.requestCameraPermissionStub = { completion in | ||
| completion?(nil) | ||
| } | ||
| mockPermissionManager.requestAudioPermissionStub = { completion in | ||
| completion?(nil) | ||
RobertOdrowaz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| mockCaptureSession.canSetSessionPreset = true | ||
|
|
||
| cameraPlugin.createCamera( | ||
| withName: "camera_name", | ||
| settings: FCPPlatformMediaSettings.make( | ||
| with: FCPPlatformResolutionPreset.medium, | ||
| framesPerSecond: nil, | ||
| videoBitrate: nil, | ||
| audioBitrate: nil, | ||
| enableAudio: true | ||
| ) | ||
| ) { result, error in | ||
| expectation.fulfill() | ||
| } | ||
|
|
||
| waitForExpectations(timeout: 30, handler: nil) | ||
|
|
||
| XCTAssertNotNil(cameraPlugin.camera) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.