Skip to content

[camera_avfoundation] Tests backfilling - part 1 #8698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Mar 5, 2025
Merged

[camera_avfoundation] Tests backfilling - part 1 #8698

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73d41b6
Backfill tests for CameraPlugin class
RobertOdrowaz Feb 24, 2025
c55ddc6
Extract forwarding method tests to separate PR
RobertOdrowaz Mar 3, 2025
ca5ceaa
Use inferred types if possible
RobertOdrowaz Mar 3, 2025
72edba6
Correct formatting
RobertOdrowaz Mar 3, 2025
f42a53d
Fix MockFLTCam formatting
RobertOdrowaz Mar 3, 2025
c746aa8
Tweak camera tests
RobertOdrowaz Mar 4, 2025
be6ff6e
Rename testCreateCamera_assignsCamera to _createsFLTCamSuccessfully
RobertOdrowaz Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use inferred types if possible
  • Loading branch information
@RobertOdrowaz
RobertOdrowaz committed Mar 3, 2025
commit ca5ceaa12c6c34ccae4281ff25e4fd9e2efc5e99
8 changes: 4 additions & 4 deletions packages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ final class AvailableCamerasTest: XCTestCase {
if #available(iOS 13.0, *) {
requiredTypes.append(.builtInUltraWideCamera)
}
var cameras: [MockCaptureDevice] = [wideAngleCamera, frontFacingCamera, telephotoCamera]
var cameras = [wideAngleCamera, frontFacingCamera, telephotoCamera]
if #available(iOS 13.0, *) {
cameras.append(ultraWideCamera)
}
Expand Down Expand Up @@ -98,7 +98,7 @@ final class AvailableCamerasTest: XCTestCase {
if #available(iOS 13.0, *) {
requiredTypes.append(.builtInUltraWideCamera)
}
let cameras: [MockCaptureDevice] = [wideAngleCamera, frontFacingCamera]
let cameras = [wideAngleCamera, frontFacingCamera]

mockDeviceDiscoverer.discoverySessionStub = { deviceTypes, mediaType, position in
XCTAssertEqual(deviceTypes, requiredTypes)
Expand Down Expand Up @@ -134,7 +134,7 @@ final class AvailableCamerasTest: XCTestCase {
if #available(iOS 13.0, *) {
requiredTypes.append(.builtInUltraWideCamera)
}
let cameras: [MockCaptureDevice] = [unspecifiedCamera]
let cameras = [unspecifiedCamera]

mockDeviceDiscoverer.discoverySessionStub = { deviceTypes, mediaType, position in
XCTAssertEqual(deviceTypes, requiredTypes)
Expand All @@ -151,6 +151,6 @@ final class AvailableCamerasTest: XCTestCase {
}
waitForExpectations(timeout: 30, handler: nil)

XCTAssertEqual(resultValue?.first?.lensDirection, FCPPlatformCameraLensDirection.external)
XCTAssertEqual(resultValue?.first?.lensDirection, .external)
}
}
6 changes: 3 additions & 3 deletions ...es/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ final class CameraPluginCreateCameraTests: XCTestCase {
cameraPlugin.createCamera(
withName: "camera_name",
settings: FCPPlatformMediaSettings.make(
with: FCPPlatformResolutionPreset.medium,
with: .medium,
framesPerSecond: nil,
videoBitrate: nil,
audioBitrate: nil,
Expand Down Expand Up @@ -79,7 +79,7 @@ final class CameraPluginCreateCameraTests: XCTestCase {
cameraPlugin.createCamera(
withName: "camera_name",
settings: FCPPlatformMediaSettings.make(
with: FCPPlatformResolutionPreset.medium,
with: .medium,
framesPerSecond: nil,
videoBitrate: nil,
audioBitrate: nil,
Expand Down Expand Up @@ -110,7 +110,7 @@ final class CameraPluginCreateCameraTests: XCTestCase {
cameraPlugin.createCamera(
withName: "camera_name",
settings: FCPPlatformMediaSettings.make(
with: FCPPlatformResolutionPreset.medium,
with: .medium,
framesPerSecond: nil,
videoBitrate: nil,
audioBitrate: nil,
Expand Down