Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test and retained fix
  • Loading branch information
bparrishMines committed Feb 28, 2025
commit 32da26aa4e67bf56cddb30d3b3d97e63cc0b1e28
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ class FrameInfoProxyAPITests: XCTestCase {

XCTAssertEqual(value?.value, instance!.request)
}

@MainActor func testNilRequest() {
let registrar = TestProxyApiRegistrar()
let api = registrar.apiDelegate.pigeonApiWKFrameInfo(registrar)

let instance = TestFrameInfoWithNilRequest()
let value = try? api.pigeonDelegate.request(pigeonApi: api, pigeonInstance: instance)

XCTAssertNil(value)
}
}

class TestFrameInfo: WKFrameInfo {
Expand All @@ -39,3 +49,9 @@ class TestFrameInfo: WKFrameInfo {
return URLRequest(url: URL(string: "https://google.com")!)
}
}

class TestFrameInfoWithNilRequest: WKFrameInfo {
override var isMainFrame: Bool {
return true
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ extension WKFrameInfo {
//
// See https://github.com/flutter/flutter/issues/163549 and https://developer.apple.com/forums/thread/77888.
var maybeRequest: URLRequest? {
return self.perform(#selector(getter: WKFrameInfo.request))?.takeUnretainedValue() as! URLRequest?
return self.perform(#selector(getter: WKFrameInfo.request))?.takeUnretainedValue()
as! URLRequest?
}
}

Expand Down