Skip to content

[webview_flutter_wkwebview] Fixes crash with nil WKFrameInfo.request #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Mar 4, 2025
Merged

[webview_flutter_wkwebview] Fixes crash with nil WKFrameInfo.request #8766

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9c4f5c
fix
bparrishMines Feb 28, 2025
7e9ee0c
remove permission_handler
bparrishMines Feb 28, 2025
4866bdb
take the unretained value
bparrishMines Feb 28, 2025
32da26a
add test and retained fix
bparrishMines Feb 28, 2025
5f48fb3
remove unused code
bparrishMines Feb 28, 2025
08dfa43
weird formatting
bparrishMines Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused code
  • Loading branch information
@bparrishMines
bparrishMines committed Feb 28, 2025
commit 5f48fb3ac830bcd0aa4a220ad3d55b4b43e1c3db
3 changes: 0 additions & 3 deletions packages/webview_flutter/webview_flutter_wkwebview/darwin/Tests/FrameInfoProxyAPITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,4 @@ class TestFrameInfo: WKFrameInfo {
}

class TestFrameInfoWithNilRequest: WKFrameInfo {
override var isMainFrame: Bool {
return true
}
}