Skip to content

[video_player_android] isBuffering flag always return true after calling seekTo method - fixed #9198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
May 23, 2025
Merged

[video_player_android] isBuffering flag always return true after calling seekTo method - fixed #9198

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf4fd71
[video_player_android] isBuffering flag always return true after call…
raju-muliyashiya May 4, 2025
e4a5254
Merge remote-tracking branch 'origin/main' into video_player_infinite…
raju-muliyashiya May 7, 2025
9f3bf4a
added native test case, update CHANGELOG.md and version pump
raju-muliyashiya May 7, 2025
22b40d2
undo CHANGELOG.md auto-formatted change
raju-muliyashiya May 13, 2025
ca70e19
Merge branch 'main' into video_player_infinite_buffer_on_seek_android…
stuartmorgan-g May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions packages/video_player/video_player_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.8.4

* Fixes a [bug](https://github.com/flutter/flutter/issues/165149) where the `isBuffering` flag
always returns true after seeking to any position.

## 2.8.3

* Changes plugin to use `TextureRegistry.SurfaceProducer.handlesCropAndRotation` to detect
Expand Down Expand Up @@ -110,7 +115,9 @@

## 2.7.0

* Re-adds [support for Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).
*

Re-adds [support for Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).
Copy link
Contributor

@camsim99 camsim99 May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change:

Suggested change
*
Re-adds [support for Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).
* Re-adds [support for Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).


## 2.6.0

Expand Down Expand Up @@ -161,7 +168,8 @@
## 2.4.12

* Updates compileSdk version to 34.
* Adds error handling for `BehindLiveWindowException`, which may occur upon live-video playback failure.
* Adds error handling for `BehindLiveWindowException`, which may occur upon live-video playback
failure.

## 2.4.11

Expand Down Expand Up @@ -208,7 +216,8 @@

## 2.4.1

* Changes the severity of `javac` warnings so that they are treated as errors and fixes the violations.
* Changes the severity of `javac` warnings so that they are treated as errors and fixes the
violations.

## 2.4.0

Expand Down Expand Up @@ -247,15 +256,17 @@
## 2.3.7

* Bumps gradle version to 7.2.1.
* Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/106316).
* Ignores unnecessary import warnings in preparation
for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/106316).

## 2.3.6

* Updates references to the obsolete master branch.

## 2.3.5

* Sets rotationCorrection for videos recorded in landscapeRight (https://github.com/flutter/flutter/issues/60327).
* Sets rotationCorrection for videos recorded in
landscapeRight (https://github.com/flutter/flutter/issues/60327).

## 2.3.4

Expand All @@ -264,7 +275,8 @@
## 2.3.3

* Removes unnecessary imports.
* Fixes library_private_types_in_public_api, sort_child_properties_last and use_key_in_widget_constructors
* Fixes library_private_types_in_public_api, sort_child_properties_last and
use_key_in_widget_constructors
lint warnings.

## 2.3.2
Expand All @@ -284,3 +296,4 @@
## 2.2.17

* Splits from `video_player` as a federated implementation.
`
Copy link
Contributor

@camsim99 camsim99 May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change too.

Also nit: the rest of the changes seem like auto-formatter changes, that are not needed.

7 changes: 3 additions & 4 deletions ..._android/android/src/main/java/io/flutter/plugins/videoplayer/ExoPlayerEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,10 @@ public void onPlaybackStateChanged(final int playbackState) {
events.onBufferingUpdate(exoPlayer.getBufferedPosition());
break;
case Player.STATE_READY:
if (isInitialized) {
return;
if (!isInitialized) {
isInitialized = true;
sendInitialized();
Copy link
Contributor

@camsim99 camsim99 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes in theory seems reasonable to me! Can you please add a test for this change?

Copy link
Contributor Author

@raju-muliyashiya raju-muliyashiya May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will add test case.

}
isInitialized = true;
sendInitialized();
break;
case Player.STATE_ENDED:
events.onCompleted();
Expand Down
13 changes: 13 additions & 0 deletions ...roid/android/src/test/java/io/flutter/plugins/videoplayer/ExoPlayerEventListenerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,19 @@ public void onPlaybackStateChangedEndedAfterBufferingSendsBufferingEndAndOnCompl
verifyNoMoreInteractions(mockCallbacks);
}

@Test
public void onPlaybackStateChangedReadyAfterBufferingSendsBufferingEnd() {
when(mockExoPlayer.getBufferedPosition()).thenReturn(10L);
eventListener.onPlaybackStateChanged(Player.STATE_BUFFERING);
verify(mockCallbacks).onBufferingStart();
verify(mockCallbacks).onBufferingUpdate(10L);

eventListener.onPlaybackStateChanged(Player.STATE_READY);
verify(mockCallbacks).onBufferingEnd();

verifyNoMoreInteractions(mockCallbacks);
}

@Test
public void onPlaybackStateChangedIdleDoNothing() {
eventListener.onPlaybackStateChanged(Player.STATE_IDLE);
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_android
description: Android implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.8.3
version: 2.8.4

environment:
sdk: ^3.6.0
Expand Down