Skip to content

[Android 16] Bumped create_all_packages_command CompileSdk to 36 #9293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Jun 4, 2025
Merged

[Android 16] Bumped create_all_packages_command CompileSdk to 36 #9293

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6adf77
create all packages command compileSdk to 36
jesswrd May 20, 2025
0184759
update test
jesswrd May 20, 2025
339b5c5
bump to legacy all_packages agp 8.1.0. fix ci error
jesswrd May 20, 2025
f813778
resolved conflicts
jesswrd Jun 3, 2025
fe570ea
bump to 36 post merge
jesswrd Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bump to legacy all_packages agp 8.1.0. fix ci error
  • Loading branch information
@jesswrd
jesswrd committed May 20, 2025
commit 339b5c5cc4fed2b9d13f45f5c70ac4a588b5968c
2 changes: 1 addition & 1 deletion .ci/legacy_project/all_packages/android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pluginManagement {
// See https://github.com/flutter/flutter/blob/master/docs/ecosystem/Plugins-and-Packages-repository-structure.md#gradle-structure for more info.
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "7.0.0" apply false
id "com.android.application" version "8.1.0" apply false
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change correspond to a Flutter Fix or similar clear instruction from a build?

Also, has an AGP 7 test of any kind been added to flutter/flutter already? Traditionally this flutter/packages test is where we've found regressions in support for older AGP versions, so if we're going to bump this it would be good to backfill testing support in flutter/flutter. (It would be good anyway so we catch things earlier, but especially important if this last line of defense is going away.)

Copy link
Contributor Author

@jesswrd jesswrd Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a Flutter fix prompt/instructions to resolve the build issue, but there is no longer a need to update the AGP version of settings.gradle in legacy_project/all_packages. Merged the changes and resolved conflicts from the all_packages bump to 35 here, and the PR includes the AGP and Gradle bump needed. all_packages on SDK 36 now successfully builds.

id "org.jetbrains.kotlin.android" version "1.9.0" apply false
}

Expand Down