Skip to content

[Android 16] Bumped create_all_packages_command CompileSdk to 36 #9293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Jun 4, 2025
Merged

[Android 16] Bumped create_all_packages_command CompileSdk to 36 #9293

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6adf77
create all packages command compileSdk to 36
jesswrd May 20, 2025
0184759
update test
jesswrd May 20, 2025
339b5c5
bump to legacy all_packages agp 8.1.0. fix ci error
jesswrd May 20, 2025
f813778
resolved conflicts
jesswrd Jun 3, 2025
fe570ea
bump to 36 post merge
jesswrd Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bump to 36 post merge
  • Loading branch information
@jesswrd
jesswrd committed Jun 3, 2025
commit fe570eae63fc7ec5d78b9a97cbf96c62d13132c5
4 changes: 2 additions & 2 deletions script/tool/lib/src/create_all_packages_app_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ dependencies {}
gradleFile,
replacements: <String, List<String>>{
if (gradleFileIsKotlin)
'compileSdk': <String>['compileSdk = 35']
'compileSdk': <String>['compileSdk = 36']
else ...<String, List<String>>{
'compileSdkVersion': <String>['compileSdk 35'],
'compileSdkVersion': <String>['compileSdk 36'],
}
},
regexReplacements: <RegExp, List<String>>{
Expand Down
4 changes: 2 additions & 2 deletions script/tool/test/create_all_packages_app_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ android {
buildGradle,
containsAll(<Matcher>[
contains('This is the legacy file'),
contains('compileSdk 35'),
contains('compileSdk 36'),
]));
});

Expand Down Expand Up @@ -372,7 +372,7 @@ android {
expect(
buildGradle,
containsAll(<Matcher>[
contains('compileSdk 35'),
contains('compileSdk 36'),
contains('androidx.lifecycle:lifecycle-runtime'),
]));
});
Expand Down