Skip to content

[video_player] Move Android to per-player-instance Pigeon APIs #9511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Jul 25, 2025
Merged

[video_player] Move Android to per-player-instance Pigeon APIs #9511

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
71cad85
Switch most methods to a per-instance API channel
stuartmorgan-g Jun 24, 2025
e3684d1
Switch remaining tests from Pigeon generated tests to mockito
stuartmorgan-g Jun 26, 2025
bc7452e
Pigeon update
stuartmorgan-g Jun 27, 2025
18d5e4b
Version bump
stuartmorgan-g Jun 27, 2025
a16cf7e
Copypasta fix
stuartmorgan-g Jun 27, 2025
b8e99a3
Merge branch 'main' into video-player-android-dart-player-instance
stuartmorgan-g Jul 8, 2025
ec2ddc7
Apply iOS review changes for consistency
stuartmorgan-g Jul 8, 2025
3406ff6
Merge branch 'main' into video-player-android-dart-player-instance
stuartmorgan-g Jul 16, 2025
f41c1b1
Gemini review feedback
stuartmorgan-g Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Copypasta fix
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g authored Jun 27, 2025
commit a16cf7e6858fa6916925852a58e73e2feacf54f7
8 changes: 4 additions & 4 deletions packages/video_player/video_player_android/lib/src/android_video_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ import 'messages.g.dart';
import 'platform_view_player.dart';

/// The non-test implementation of `_apiProvider`.
VideoPlayerInstanceApi _productionApiProvider(int mapId) {
return VideoPlayerInstanceApi(messageChannelSuffix: mapId.toString());
VideoPlayerInstanceApi _productionApiProvider(int playerId) {
return VideoPlayerInstanceApi(messageChannelSuffix: playerId.toString());
}

/// An Android implementation of [VideoPlayerPlatform] that uses the
/// Pigeon-generated [VideoPlayerApi].
class AndroidVideoPlayer extends VideoPlayerPlatform {
/// Creates a new Android maps implementation instance.
/// Creates a new Android video player implementation instance.
AndroidVideoPlayer({
@visibleForTesting AndroidVideoPlayerApi? pluginApi,
@visibleForTesting
Expand All @@ -30,7 +30,7 @@ class AndroidVideoPlayer extends VideoPlayerPlatform {
final AndroidVideoPlayerApi _api;
// A method to create VideoPlayerInstanceApi instances, which can be
//overridden for testing.
final VideoPlayerInstanceApi Function(int mapId) _apiProvider;
final VideoPlayerInstanceApi Function(int playerId) _apiProvider;

/// A map that associates player ID with a view state.
/// This is used to determine which view type to use when building a view.
Expand Down