Skip to content

[video_player] Move Android to per-player-instance Pigeon APIs #9511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Jul 25, 2025
Merged

[video_player] Move Android to per-player-instance Pigeon APIs #9511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
71cad85
Switch most methods to a per-instance API channel
stuartmorgan-g Jun 24, 2025
e3684d1
Switch remaining tests from Pigeon generated tests to mockito
stuartmorgan-g Jun 26, 2025
bc7452e
Pigeon update
stuartmorgan-g Jun 27, 2025
18d5e4b
Version bump
stuartmorgan-g Jun 27, 2025
a16cf7e
Copypasta fix
stuartmorgan-g Jun 27, 2025
b8e99a3
Merge branch 'main' into video-player-android-dart-player-instance
stuartmorgan-g Jul 8, 2025
ec2ddc7
Apply iOS review changes for consistency
stuartmorgan-g Jul 8, 2025
3406ff6
Merge branch 'main' into video-player-android-dart-player-instance
stuartmorgan-g Jul 16, 2025
f41c1b1
Gemini review feedback
stuartmorgan-g Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Gemini review feedback
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jul 16, 2025
commit f41c1b1ca4e1f9e1757ec7d33ada8aa067116e47
2 changes: 1 addition & 1 deletion ...ideo_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public void setPlaybackSpeed(@NonNull Double speed) {

@Override
public void seekTo(@NonNull Long position) {
exoPlayer.seekTo(position.intValue());
exoPlayer.seekTo(position);
}

@NonNull
Expand Down
2 changes: 1 addition & 1 deletion ...layer_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public void initialize() {
// Set up the instance-specific API handler, and make sure it is removed when the player is
// disposed.
BinaryMessenger messenger = flutterState.binaryMessenger;
final String channelSuffix = Integer.toString((int) id);
final String channelSuffix = Long.toString(id);
VideoPlayerInstanceApi.setUp(messenger, channelSuffix, videoPlayer);
videoPlayer.setDisposeHandler(
() -> VideoPlayerInstanceApi.setUp(messenger, channelSuffix, null));
Expand Down
2 changes: 1 addition & 1 deletion ..._player_android/android/src/test/java/io/flutter/plugins/videoplayer/VideoPlayerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public void seekAndGetPosition() {
verify(mockExoPlayer).seekTo(10);

when(mockExoPlayer.getCurrentPosition()).thenReturn(20L);
assertEquals(20L, videoPlayer.getPosition().doubleValue(), 0.001);
assertEquals(20L, videoPlayer.getPosition().longValue());
}

@Test
Expand Down