Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[package_info] Migrate to null safety #3398

Merged
bparrishMines merged 12 commits into from
Feb 4, 2021
Merged

[package_info] Migrate to null safety #3398

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0021bef
migrate to null safety
bparrishMines Dec 28, 2020
c76b56c
update
bparrishMines Jan 6, 2021
3083760
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Jan 6, 2021
1d7b6fc
use min dependency and fix example warning
bparrishMines Jan 7, 2021
08b6bd2
null check future return value and use local variable
bparrishMines Jan 11, 2021
7092d00
seperate declaration and return statement
bparrishMines Jan 11, 2021
d2b1466
add to nnbd plugins list
bparrishMines Jan 13, 2021
a5f22e9
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Jan 16, 2021
29c6f8b
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Jan 25, 2021
c28e3fe
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Feb 3, 2021
9f1af8d
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Feb 4, 2021
bd08214
reverting example dir back to master
bparrishMines Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
null check future return value and use local variable
  • Loading branch information
@bparrishMines
bparrishMines committed Jan 11, 2021
commit 08b6bd23bcbfc75740ec661c97d43963bdff83e7
11 changes: 5 additions & 6 deletions packages/package_info/lib/package_info.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,13 @@ class PackageInfo {
/// Retrieves package information from the platform.
/// The result is cached.
static Future<PackageInfo> fromPlatform() async {
if (_fromPlatform != null) {
return _fromPlatform!;
}
final PackageInfo? packageInfo = _fromPlatform;
if (packageInfo != null) return packageInfo;

final Map<String, dynamic>? map =
await _kChannel.invokeMapMethod<String, dynamic>('getAll');
final Map<String, dynamic> map =
(await _kChannel.invokeMapMethod<String, dynamic>('getAll'))!;
return _fromPlatform = PackageInfo(
Copy link

@blasten blasten Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably a bit more readable to have this as two separate statements

appName: map!["appName"],
appName: map["appName"],
packageName: map["packageName"],
version: map["version"],
buildNumber: map["buildNumber"],
Expand Down