Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[package_info] Migrate to null safety #3398

Merged
bparrishMines merged 12 commits into from
Feb 4, 2021
Merged

[package_info] Migrate to null safety #3398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0021bef
migrate to null safety
bparrishMines Dec 28, 2020
c76b56c
update
bparrishMines Jan 6, 2021
3083760
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Jan 6, 2021
1d7b6fc
use min dependency and fix example warning
bparrishMines Jan 7, 2021
08b6bd2
null check future return value and use local variable
bparrishMines Jan 11, 2021
7092d00
seperate declaration and return statement
bparrishMines Jan 11, 2021
d2b1466
add to nnbd plugins list
bparrishMines Jan 13, 2021
a5f22e9
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Jan 16, 2021
29c6f8b
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Jan 25, 2021
c28e3fe
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Feb 3, 2021
9f1af8d
Merge branch 'master' of github.com:flutter/plugins into package_info…
bparrishMines Feb 4, 2021
bd08214
reverting example dir back to master
bparrishMines Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
reverting example dir back to master
  • Loading branch information
@bparrishMines
bparrishMines committed Feb 4, 2021
commit bd082149baeb85e0065f66229c644e5f485b2521
2 changes: 0 additions & 2 deletions packages/package_info/example/integration_test/package_info_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

import 'dart:io';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';
Copy link

@blasten blasten Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnfield I couldn't find an issue about migrating vm_service to null safe. Do you know if there's any work in the radar?

Copy link
Contributor

@dnfield dnfield Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like per dart-lang/sdk#40046 it's been landed. We can look to migrate integration_test and driver.

Copy link

@blasten blasten Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@dnfield dnfield Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong. That's for a different part of the SDK. Migration is still ongoing, Dart cl is https://dart-review.googlesource.com/c/sdk/+/156980

Expand Down
4 changes: 2 additions & 2 deletions packages/package_info/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class MyApp extends StatelessWidget {
}

class MyHomePage extends StatefulWidget {
MyHomePage({Key? key, required this.title}) : super(key: key);
MyHomePage({Key key, this.title}) : super(key: key);

final String title;

Expand Down Expand Up @@ -57,7 +57,7 @@ class _MyHomePageState extends State<MyHomePage> {
Widget _infoTile(String title, String subtitle) {
return ListTile(
title: Text(title),
subtitle: Text(subtitle),
subtitle: Text(subtitle ?? 'Not set'),
);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/package_info/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ dependencies:
dev_dependencies:
flutter_driver:
sdk: flutter
pedantic: ^1.10.0-nullsafety
pedantic: ^1.8.0

flutter:
uses-material-design: true

environment:
sdk: ">=2.12.0-0 <3.0.0"
sdk: ">=2.1.0 <3.0.0"
flutter: ">=1.12.13+hotfix.5 <2.0.0"
2 changes: 0 additions & 2 deletions packages/package_info/example/test_driver/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

import 'dart:convert';
import 'dart:io';

Expand Down