Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review
  • Loading branch information
Chris Yang committed Apr 7, 2021
commit 01b8d80297fdda601e9a96bd7b7a21c225b6c788
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,6 @@ void main() {
Completer<WebViewController> controllerCompleter =
Completer<WebViewController>();
Completer<void> pageLoaded = Completer<void>();
// String message1;
Completer<void> videoPlaying = Completer<void>();

await tester.pumpWidget(
Expand Down Expand Up @@ -541,7 +540,6 @@ void main() {
Completer<WebViewController> controllerCompleter =
Completer<WebViewController>();
Completer<void> pageLoaded = Completer<void>();
// String message1;
Completer<void> videoPlaying = Completer<void>();

await tester.pumpWidget(
Expand Down
4 changes: 2 additions & 2 deletions packages/webview_flutter/ios/Classes/FlutterWebView.m
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,8 @@ - (NSString*)applySettings:(NSDictionary<NSString*, id>*)settings {
[unknownKeys componentsJoinedByString:@", "]];
}

- (void)applyConfigurationSetting:(NSDictionary<NSString*, id>*)settings
inConfiguration:(WKWebViewConfiguration*)configuration {
- (void)applyConfigurationSettings:(NSDictionary<NSString*, id>*)settings
toConfiguration:(WKWebViewConfiguration*)configuration {
NSAssert(configuration != _webView.configuration,
@"configuration needs to be updated before webView.configuration.");
for (NSString* key in settings) {
Expand Down