Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_webview] Fix allowsInlineMediaPlayback ignored on iOS #3791

Merged
fluttergithubbot merged 9 commits into from
Apr 7, 2021
Merged

[flutter_webview] Fix allowsInlineMediaPlayback ignored on iOS #3791

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1736cec
draft
Apr 6, 2021
24f6c20
draft
Apr 6, 2021
43db4eb
fix tests
Apr 6, 2021
d19923e
enable skipped tests
Apr 7, 2021
0b5ba7c
format
Apr 7, 2021
bb1afa1
version
Apr 7, 2021
01b8d80
review
Apr 7, 2021
d2da73b
fix
Apr 7, 2021
6d6ee46
format
Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
Chris Yang committed Apr 7, 2021
commit 0b5ba7c117083f822d339149210b2688efc197f1
6 changes: 4 additions & 2 deletions packages/webview_flutter/ios/Classes/FlutterWebView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,10 @@ - (NSString*)applySettings:(NSDictionary<NSString*, id>*)settings {
[unknownKeys componentsJoinedByString:@", "]];
}

- (void)applyConfigurationSetting:(NSDictionary<NSString*, id>*)settings inConfiguration:(WKWebViewConfiguration*)configuration {
NSAssert(configuration != _webView.configuration, @"configuration needs to be updated before webView.configuration.");
- (void)applyConfigurationSetting:(NSDictionary<NSString*, id>*)settings
inConfiguration:(WKWebViewConfiguration*)configuration {
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/in/to/

Copy link
Contributor Author

@cyanglaz cyanglaz Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also did s/Setting/Settings

NSAssert(configuration != _webView.configuration,
@"configuration needs to be updated before webView.configuration.");
for (NSString* key in settings) {
if ([key isEqualToString:@"allowsInlineMediaPlayback"]) {
NSNumber* allowsInlineMediaPlayback = settings[key];
Expand Down