Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Improve the camera example with controllers initializations #5748

Closed
AlexV525 wants to merge 8 commits into from
Closed

[camera] Improve the camera example with controllers initializations #5748

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
436f5b4
⚡️ Only update the controller if it's initialized successfully
AlexV525 May 15, 2022
23a03f9
🎨 Format
AlexV525 May 15, 2022
264dab6
🔖 0.9.5+1
AlexV525 May 15, 2022
89ff144
🔥 Remove condition and add comments
AlexV525 May 20, 2022
dfb46c8
💡 Update comment
AlexV525 May 23, 2022
d9c2e61
🎨 Trailing comma
AlexV525 May 23, 2022
4b5862d
Merge branch 'main' into improve-camera-example
AlexV525 May 23, 2022
764d0b4
🚑️ Fix reverted web condition
AlexV525 May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
⚡️ Only update the controller if it's initialized successfully
  • Loading branch information
@AlexV525
AlexV525 committed May 15, 2022
commit 436f5b4c4868315c1307e99d676c4564fad6a599
9 changes: 7 additions & 2 deletions packages/camera/camera/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,6 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
imageFormatGroup: ImageFormatGroup.jpeg,
);

controller = cameraController;
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, wouldn't two calls to onNewCameraSelected in rapid succession have a race where a controller would be replaced without being disposed?

Copy link
Member Author

@AlexV525 AlexV525 Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not covered in this PR yet. Let me know if the example can be updated/refactored for better architecture or for test purposes.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, anything we can do to make the example better is a win. We should try to make sure that testability changes are minimally intrusive when possible so they don't distract from understanding of the example itself.


// If the controller is updated then update the UI.
cameraController.addListener(() {
if (mounted) {
Expand All @@ -666,6 +664,12 @@ class _CameraExampleHomeState extends State<CameraExampleHome>

try {
await cameraController.initialize();
if (cameraController.value.hasError) {
showInSnackBar(
'Camera error ${cameraController.value.errorDescription}',
);
return;
}
await Future.wait(<Future<Object?>>[
// The exposure mode is currently not supported on the web.
...!kIsWeb
Expand All @@ -684,6 +688,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
.getMinZoomLevel()
.then((double value) => _minAvailableZoom = value),
]);
controller = cameraController;
} on CameraException catch (e) {
switch (e.code) {
case 'CameraAccessDenied':
Expand Down