Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Improve the camera example with controllers initializations #5748

Closed
AlexV525 wants to merge 8 commits into from
Closed

[camera] Improve the camera example with controllers initializations #5748

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
436f5b4
⚡️ Only update the controller if it's initialized successfully
AlexV525 May 15, 2022
23a03f9
🎨 Format
AlexV525 May 15, 2022
264dab6
🔖 0.9.5+1
AlexV525 May 15, 2022
89ff144
🔥 Remove condition and add comments
AlexV525 May 20, 2022
dfb46c8
💡 Update comment
AlexV525 May 23, 2022
d9c2e61
🎨 Trailing comma
AlexV525 May 23, 2022
4b5862d
Merge branch 'main' into improve-camera-example
AlexV525 May 23, 2022
764d0b4
🚑️ Fix reverted web condition
AlexV525 May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🔥 Remove condition and add comments
  • Loading branch information
@AlexV525
AlexV525 committed May 20, 2022
commit 89ff1447ac136dfc3a3e79d4db742ebb0ad4e1a9
11 changes: 5 additions & 6 deletions packages/camera/camera/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,12 +665,6 @@ class _CameraExampleHomeState extends State<CameraExampleHome>

try {
await cameraController.initialize();
if (cameraController.value.hasError) {
showInSnackBar(
'Camera error ${cameraController.value.errorDescription}',
);
return;
}
await Future.wait(<Future<Object?>>[
// The exposure mode is currently not supported on the web.
if (kIsWeb) ...<Future<Object?>>[
Expand All @@ -688,6 +682,11 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
.getMinZoomLevel()
.then((double value) => _minAvailableZoom = value),
]);
// `controller` needs to be set until it's fully initialized, to avoid a
// race condition when the lifecycle callback being called and creates a
// new `controller`. This happens when the camera permission dialog
// dismisses at the first run, which triggers `didChangeAppLifecycleState`
// that disposes and re-creates the controller.
controller = cameraController;
} on CameraException catch (e) {
switch (e.code) {
Expand Down