Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Prevent leaking when a callback method references an object that references itself #6056

Merged
fluttergithubbot merged 17 commits into from
Jul 7, 2022
Merged

[webview_flutter_wkwebview] Prevent leaking when a callback method references an object that references itself #6056

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
63478a1
prevent leaks
bparrishMines Jun 27, 2022
1c8bd6c
change doc
bparrishMines Jun 28, 2022
a41be67
some experiments
bparrishMines Jun 29, 2022
308dee8
use weak reference callback
bparrishMines Jun 29, 2022
6731367
create a weakref helper method
bparrishMines Jun 29, 2022
96077cb
tests running but failing
bparrishMines Jun 29, 2022
f468f2c
some test progress
bparrishMines Jun 29, 2022
6596bd7
use weak reference helper
bparrishMines Jun 29, 2022
2af6812
docs and remove runGarbageCollection
bparrishMines Jun 30, 2022
1114c07
unused imports
bparrishMines Jun 30, 2022
c66e8ec
license
bparrishMines Jun 30, 2022
75cab29
remove async from test
bparrishMines Jun 30, 2022
2f9e913
add a test
bparrishMines Jun 30, 2022
7b9261f
include weakReferenceTo in doc
bparrishMines Jun 30, 2022
1610344
move test to integration test
bparrishMines Jun 30, 2022
5f51fbd
dont print
bparrishMines Jun 30, 2022
bba8625
organize imports
bparrishMines Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unused imports
  • Loading branch information
@bparrishMines
bparrishMines committed Jun 30, 2022
commit 1114c07e455475403ac7469078ce6e8e14c51c18
4 changes: 0 additions & 4 deletions packages/webview_flutter/webview_flutter_wkwebview/test/src/web_kit_webview_widget_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:developer';
import 'dart:isolate';
import 'dart:math';
// TODO(a14n): remove this import once Flutter 3.1 or later reaches stable (including flutter/flutter#106316)
// ignore: unnecessary_import
Expand All @@ -14,8 +12,6 @@ import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mockito/annotations.dart';
import 'package:mockito/mockito.dart';
import 'package:vm_service/vm_service.dart' as vm_service;
import 'package:vm_service/vm_service_io.dart' as vm_service_io;
import 'package:webview_flutter_platform_interface/webview_flutter_platform_interface.dart';
import 'package:webview_flutter_wkwebview/src/foundation/foundation.dart';
import 'package:webview_flutter_wkwebview/src/ui_kit/ui_kit.dart';
Expand Down