Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs and remove runGarbageCollection
  • Loading branch information
bparrishMines committed Jun 30, 2022
commit 2af6812ec825b2eb71be56057108b3e5daa02854
Original file line number Diff line number Diff line change
@@ -1,4 +1,26 @@
/// Helper method for creating callbacks methods with a weak reference.
///
/// Example:
/// ```
/// final JavascriptChannelRegistry javascriptChannelRegistry = ...
///
/// final WKScriptMessageHandler handler = WKScriptMessageHandler(
/// didReceiveScriptMessage: withWeakRefenceTo(
/// javascriptChannelRegistry,
/// (WeakReference<JavascriptChannelRegistry> weakReference) {
/// return (
/// WKUserContentController userContentController,
/// WKScriptMessage message,
/// ) {
/// weakReference.target?.onJavascriptChannelMessage(
/// message.name,
/// message.body!.toString(),
/// );
/// };
/// },
/// ),
/// );
/// ```
S withWeakRefenceTo<T extends Object, S extends Object>(
T reference,
S Function(WeakReference<T> weakReference) onCreate,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,3 @@ dev_dependencies:
mockito: ^5.1.0
pedantic: ^1.10.0
pigeon: ^3.0.3
vm_service: ">=8.3.0 <10.0.0"
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,6 @@ import 'package:webview_flutter_wkwebview/src/web_kit_webview_widget.dart';

import 'web_kit_webview_widget_test.mocks.dart';

List<String> _cleanupPathSegments(Uri uri) {
final List<String> pathSegments = <String>[];
if (uri.pathSegments.isNotEmpty) {
pathSegments.addAll(uri.pathSegments.where(
(String s) => s.isNotEmpty,
));
}
return pathSegments;
}

String _toWebSocket(Uri uri) {
final List<String> pathSegments = _cleanupPathSegments(uri);
pathSegments.add('ws');
return uri.replace(scheme: 'ws', pathSegments: pathSegments).toString();
}

@GenerateMocks(<Type>[
UIScrollView,
WKNavigationDelegate,
Expand Down Expand Up @@ -149,14 +133,6 @@ void main() async {
await tester.pumpAndSettle();
}

Future<void> runGarbageCollection() async {
final Uri? serverUri = (await Service.getInfo()).serverUri;
final String isolateId = Service.getIsolateID(Isolate.current)!;
final vm_service.VmService vmService =
await vm_service_io.vmServiceConnectUri(_toWebSocket(serverUri!));
await vmService.getAllocationProfile(isolateId, gc: true);
}

testWidgets('build $WebKitWebViewWidget', (WidgetTester tester) async {
await buildWidget(tester);
});
Expand Down