Skip to content

Add DartPad to flutter.dev #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legalcodes merged 17 commits into from
Sep 27, 2019
Merged

Add DartPad to flutter.dev #2938

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
39f9584
Added dartpad but with old examples from dart.dev
legalcodes Aug 22, 2019
1c5fcab
Updated dartpad to flutter mode + light theme
legalcodes Aug 22, 2019
54abe74
Refactor to counter example
legalcodes Aug 22, 2019
377b54e
Added 3 working examples, added dartpad to install page
legalcodes Aug 27, 2019
bcdca05
Add an include in index
legalcodes Sep 13, 2019
7b0d751
Add style and language updates to /docs/get-started/install:
legalcodes Sep 21, 2019
92dad6c
Minor updates/corrections
legalcodes Sep 21, 2019
71994fe
Fix broken link for chrome os
legalcodes Sep 23, 2019
3b4980b
Add styling tweak to dartpad section on landing page
legalcodes Sep 24, 2019
30105a3
Use 'Install Flutter' on landing page
legalcodes Sep 24, 2019
91cbf66
Fix typo
legalcodes Sep 24, 2019
11f0c9a
Rebuild dartpad_picker
legalcodes Sep 24, 2019
57403b6
Remove warning about Chrome 77
legalcodes Sep 24, 2019
ecbeef7
Left-align headings on install page
legalcodes Sep 25, 2019
75f3682
Remove changes to install page
legalcodes Sep 26, 2019
90685d8
Remove changes to sidenav for install page
legalcodes Sep 26, 2019
52ac743
Merge branch 'master' of https://github.com/flutter/website into dart…
legalcodes Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@legalcodes
legalcodes committed Sep 24, 2019
commit 91cbf66e3fa7cd39b280765d8446bf8b34aa42e1
2 changes: 1 addition & 1 deletion src/_packages/dartpad_picker/web/dartpad_picker_main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ void main() {
var select = querySelector('#dartpad-select');

var snippets = [
Snippet('Spinning flutter', spinning_logo),
Snippet('Spinning Flutter', spinning_logo),
Snippet('Fibonacci', fibonacci),
Snippet('Counter', counter),
Copy link
Contributor

@johnpryan johnpryan Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with this and the todo examples is that they require Chrome 77 to work well ( dart-lang/dart-pad#1223).

Copy link
Contributor

@sfshaza2 sfshaza2 Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think that just before or after the first DartPad instance, there should be a warning about the version of Chrome that you need.

Copy link
Contributor Author

@legalcodes legalcodes Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, as discussed we'll:

  1. Wait until 77
  2. add a warning about the Chrome version

];
Expand Down