Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ node_modules
.flutter-plugins
.packages
.dart_tool
# pubspec.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @legalcodes @johnpryan et all. Why was it decided that we'd start committing the pubspec.lock files contained in the repo?

Copy link
Contributor

@chalin chalin Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey all, I created a fresh issue to discuss this (#3107) rather than only having a comment in an old PR. (Sorry for the email notification noise.)

Copy link
Contributor

@chalin chalin Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, my bad, I wasn't looking at this edit carefully: you just deleted a commented out line! I'm the one who commented it out in #1237 last year. I didn't realize that it had been that long. I thought that it was a change that had been done in the last 6 months or so. Apologies!

FYI, I'll still go ahead a remove the pubspec.lock files.

example.g
tmp/

Expand Down
11 changes: 11 additions & 0 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,17 @@ alert:
<i class="fas fa-exclamation-triangle"></i> **Warning:**
end: </aside>

custom:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably drop this custom field/tag at some point.

dartpad:
embed-dart-prefix: https://dartpad.dev/embed-dart.html
embed-html-prefix: https://dartpad.dev/embed-html.html
embed-inline-prefix: https://dartpad.dev/embed-inline.html
dartpadx:
embed-dart-prefix: https://dartpad.dev/experimental/embed-new-dart.html
embed-flutter-prefix: https://dartpad.dev/experimental/embed-new-flutter.html
embed-html-prefix: https://dartpad.dev/experimental/embed-new-html.html
embed-inline-prefix: https://dartpad.dev/experimental/embed-new-inline.html

# callout_danger: '<div class="bs-callout bs-callout-danger">'
# callout_default: '<div class="bs-callout bs-callout-default">'
# callout_primary: '<div class="bs-callout bs-callout-primary">'
Expand Down
Loading