-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add DartPad to flutter.dev #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
39f9584
Added dartpad but with old examples from dart.dev
legalcodes 1c5fcab
Updated dartpad to flutter mode + light theme
legalcodes 54abe74
Refactor to counter example
legalcodes 377b54e
Added 3 working examples, added dartpad to install page
legalcodes bcdca05
Add an include in index
legalcodes 7b0d751
Add style and language updates to /docs/get-started/install:
legalcodes 92dad6c
Minor updates/corrections
legalcodes 71994fe
Fix broken link for chrome os
legalcodes 3b4980b
Add styling tweak to dartpad section on landing page
legalcodes 30105a3
Use 'Install Flutter' on landing page
legalcodes 91cbf66
Fix typo
legalcodes 11f0c9a
Rebuild dartpad_picker
legalcodes 57403b6
Remove warning about Chrome 77
legalcodes ecbeef7
Left-align headings on install page
legalcodes 75f3682
Remove changes to install page
legalcodes 90685d8
Remove changes to sidenav for install page
legalcodes 52ac743
Merge branch 'master' of https://github.com/flutter/website into dart…
legalcodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,6 @@ node_modules | |
| .flutter-plugins | ||
| .packages | ||
| .dart_tool | ||
| # pubspec.lock | ||
| example.g | ||
| tmp/ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,6 +116,17 @@ alert: | |
| <i class="fas fa-exclamation-triangle"></i> **Warning:** | ||
| end: </aside> | ||
|
|
||
| custom: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably drop this |
||
| dartpad: | ||
| embed-dart-prefix: https://dartpad.dev/embed-dart.html | ||
| embed-html-prefix: https://dartpad.dev/embed-html.html | ||
| embed-inline-prefix: https://dartpad.dev/embed-inline.html | ||
| dartpadx: | ||
| embed-dart-prefix: https://dartpad.dev/experimental/embed-new-dart.html | ||
| embed-flutter-prefix: https://dartpad.dev/experimental/embed-new-flutter.html | ||
| embed-html-prefix: https://dartpad.dev/experimental/embed-new-html.html | ||
| embed-inline-prefix: https://dartpad.dev/experimental/embed-new-inline.html | ||
|
|
||
| # callout_danger: '<div class="bs-callout bs-callout-danger">' | ||
| # callout_default: '<div class="bs-callout bs-callout-default">' | ||
| # callout_primary: '<div class="bs-callout bs-callout-primary">' | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @legalcodes @johnpryan et all. Why was it decided that we'd start committing the
pubspec.lockfiles contained in the repo?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey all, I created a fresh issue to discuss this (#3107) rather than only having a comment in an old PR. (Sorry for the email notification noise.)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups, my bad, I wasn't looking at this edit carefully: you just deleted a commented out line! I'm the one who commented it out in #1237 last year. I didn't realize that it had been that long. I thought that it was a change that had been done in the last 6 months or so. Apologies!
FYI, I'll still go ahead a remove the
pubspec.lockfiles.