Fixing float bugs #746
Merged
Fixing float bugs #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: added two tests for MergeWithFloat and AddWithFloat.
…wo FORM words. - Also added a test for these extreme floats.
- removed spurious warning about missing numerical implementation for functions that do not evaluate numerically after the Evaluate statement, - rational coefficients multiplied by symbols that remain unevaluated were incorrectly converted to floating-point coefficients.
- ClearfFloat and ClearMZVTables are called at the beginning of DoStartFloat to clean up any previous float systems. - Removed redundant cleanup code from SetupMZVTables, SetupMPFTables and SetfFloatPrecision as cleanup is now handled in DoStartFloat.
… reserved function names for FORM build without floating point capabilities.
…rong and even be negative. - It is now increased iteratively until it meets the required precision. - This also fixes the remaining rounding issues in the euler_ and mzvhalf_ tests (see PR699). - furthermore, the raw form in the Float_1 test has been slightly adjusted.
…ests for the StrictRounding statement to have full coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of bugs for the floating point system.