Skip to content

Fixing float bugs #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbmarini merged 7 commits into from
Dec 9, 2025
+271 −123
Merged

Fixing float bugs #746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16a289e
fix: fixed a few small bugs in MergeWithFloat.
cbmarini Oct 24, 2025
db8636d
fix: fixed a small bug in UnpackFloat for large exponents that take t…
cbmarini Oct 30, 2025
8ae5570
fix: this fixes two small bugs for the Evaluate-statement:
cbmarini Nov 6, 2025
0e73620
fix: a new call to #startfloat without a previous #endfloat could crash
cbmarini Nov 7, 2025
17cdc98
refactor: the new float functions, e.g. float_, mzv_ etc are now also…
cbmarini Nov 11, 2025
8e537a3
fix: the estimate for jmax in SimpleDelta and SimpleDeltaC could be w…
cbmarini Nov 11, 2025
117a774
fix: fixed the compiler warning in CoStrictRounding. Added two more t…
cbmarini Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fixed a small bug in UnpackFloat for large exponents that take t… 
…wo FORM words.

 - Also added a test for these extreme floats.
  • Loading branch information
@cbmarini
cbmarini committed Dec 9, 2025
commit db8636d4a54e84344120b55f3f4668ff9e365cd5
138 changes: 138 additions & 0 deletions check/features.frm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,6 +1640,144 @@ Print;
assert succeeded?
assert result("F") =~ expr("1")
*--#] AddWithFloat :
*--#[ float_extremes :
#StartFloat 10d
CFunction f;
#do i = 0,62
Local F`i' = 1.`i'e{2^`i'}*f({2^`i'});
Local G`i' = 1.`i'e{-2^`i'}*f({2^`i'});
#enddo
Print;
.end
#pend_if wordsize == 2
assert succeeded?
assert result("F0") =~ expr("1.0e+01*f(1)")
assert result("G0") =~ expr("1.0e-01*f(1)")
assert result("F1") =~ expr("1.1e+02*f(2)")
assert result("G1") =~ expr("1.1e-02*f(2)")
assert result("F2") =~ expr("1.2e+04*f(4)")
assert result("G2") =~ expr("1.2e-04*f(4)")
assert result("F3") =~ expr("1.3e+08*f(8)")
assert result("G3") =~ expr("1.3e-08*f(8)")
assert result("F4") =~ expr("1.4e+16*f(16)")
assert result("G4") =~ expr("1.4e-16*f(16)")
assert result("F5") =~ expr("1.5e+32*f(32)")
assert result("G5") =~ expr("1.5e-32*f(32)")
assert result("F6") =~ expr("1.6e+64*f(64)")
assert result("G6") =~ expr("1.6e-64*f(64)")
assert result("F7") =~ expr("1.7e+128*f(128)")
assert result("G7") =~ expr("1.7e-128*f(128)")
assert result("F8") =~ expr("1.8e+256*f(256)")
assert result("G8") =~ expr("1.8e-256*f(256)")
assert result("F9") =~ expr("1.9e+512*f(512)")
assert result("G9") =~ expr("1.9e-512*f(512)")
assert result("F10") =~ expr("1.1e+1024*f(1024)")
assert result("G10") =~ expr("1.1e-1024*f(1024)")
assert result("F11") =~ expr("1.11e+2048*f(2048)")
assert result("G11") =~ expr("1.11e-2048*f(2048)")
assert result("F12") =~ expr("1.12e+4096*f(4096)")
assert result("G12") =~ expr("1.12e-4096*f(4096)")
assert result("F13") =~ expr("1.13e+8192*f(8192)")
assert result("G13") =~ expr("1.13e-8192*f(8192)")
assert result("F14") =~ expr("1.14e+16384*f(16384)")
assert result("G14") =~ expr("1.14e-16384*f(16384)")
assert result("F15") =~ expr("1.15e+32768*f(32768)")
assert result("G15") =~ expr("1.15e-32768*f(32768)")
assert result("F16") =~ expr("1.16e+65536*f(65536)")
assert result("G16") =~ expr("1.16e-65536*f(65536)")
assert result("F17") =~ expr("1.17e+131072*f(131072)")
assert result("G17") =~ expr("1.17e-131072*f(131072)")
assert result("F18") =~ expr("1.18e+262144*f(262144)")
assert result("G18") =~ expr("1.18e-262144*f(262144)")
assert result("F19") =~ expr("1.19e+524288*f(524288)")
assert result("G19") =~ expr("1.19e-524288*f(524288)")
assert result("F20") =~ expr("1.2e+1048576*f(1048576)")
assert result("G20") =~ expr("1.2e-1048576*f(1048576)")
assert result("F21") =~ expr("1.21e+2097152*f(2097152)")
assert result("G21") =~ expr("1.21e-2097152*f(2097152)")
assert result("F22") =~ expr("1.22e+4194304*f(4194304)")
assert result("G22") =~ expr("1.22e-4194304*f(4194304)")
assert result("F23") =~ expr("1.23e+8388608*f(8388608)")
assert result("G23") =~ expr("1.23e-8388608*f(8388608)")
assert result("F24") =~ expr("1.24e+16777216*f(16777216)")
assert result("G24") =~ expr("1.24e-16777216*f(16777216)")
assert result("F25") =~ expr("1.25e+33554432*f(33554432)")
assert result("G25") =~ expr("1.25e-33554432*f(33554432)")
assert result("F26") =~ expr("1.26e+67108864*f(67108864)")
assert result("G26") =~ expr("1.26e-67108864*f(67108864)")
assert result("F27") =~ expr("1.27e+134217728*f(134217728)")
assert result("G27") =~ expr("1.27e-134217728*f(134217728)")
assert result("F28") =~ expr("1.28e+268435456*f(268435456)")
assert result("G28") =~ expr("1.28e-268435456*f(268435456)")
assert result("F29") =~ expr("1.29e+536870912*f(536870912)")
assert result("G29") =~ expr("1.29e-536870912*f(536870912)")
assert result("F30") =~ expr("1.3e+1073741824*f(1073741824)")
assert result("G30") =~ expr("1.3e-1073741824*f(1073741824)")
assert result("F31") =~ expr("1.31e+2147483648*f(2147483648)")
assert result("G31") =~ expr("1.31e-2147483648*f(2147483648)")
assert result("F32") =~ expr("1.32e+4294967296*f(4294967296)")
assert result("G32") =~ expr("1.32e-4294967296*f(4294967296)")
assert result("F33") =~ expr("1.33e+8589934592*f(8589934592)")
assert result("G33") =~ expr("1.33e-8589934592*f(8589934592)")
assert result("F34") =~ expr("1.34e+17179869184*f(17179869184)")
assert result("G34") =~ expr("1.34e-17179869184*f(17179869184)")
assert result("F35") =~ expr("1.35e+34359738368*f(34359738368)")
assert result("G35") =~ expr("1.35e-34359738368*f(34359738368)")
assert result("F36") =~ expr("1.36e+68719476736*f(68719476736)")
assert result("G36") =~ expr("1.36e-68719476736*f(68719476736)")
assert result("F37") =~ expr("1.37e+137438953472*f(137438953472)")
assert result("G37") =~ expr("1.37e-137438953472*f(137438953472)")
assert result("F38") =~ expr("1.38e+274877906944*f(274877906944)")
assert result("G38") =~ expr("1.38e-274877906944*f(274877906944)")
assert result("F39") =~ expr("1.39e+549755813888*f(549755813888)")
assert result("G39") =~ expr("1.39e-549755813888*f(549755813888)")
assert result("F40") =~ expr("1.4e+1099511627776*f(1099511627776)")
assert result("G40") =~ expr("1.4e-1099511627776*f(1099511627776)")
assert result("F41") =~ expr("1.41e+2199023255552*f(2199023255552)")
assert result("G41") =~ expr("1.41e-2199023255552*f(2199023255552)")
assert result("F42") =~ expr("1.42e+4398046511104*f(4398046511104)")
assert result("G42") =~ expr("1.42e-4398046511104*f(4398046511104)")
assert result("F43") =~ expr("1.43e+8796093022208*f(8796093022208)")
assert result("G43") =~ expr("1.43e-8796093022208*f(8796093022208)")
assert result("F44") =~ expr("1.44e+17592186044416*f(17592186044416)")
assert result("G44") =~ expr("1.44e-17592186044416*f(17592186044416)")
assert result("F45") =~ expr("1.45e+35184372088832*f(35184372088832)")
assert result("G45") =~ expr("1.45e-35184372088832*f(35184372088832)")
assert result("F46") =~ expr("1.46e+70368744177664*f(70368744177664)")
assert result("G46") =~ expr("1.46e-70368744177664*f(70368744177664)")
assert result("F47") =~ expr("1.47e+140737488355328*f(140737488355328)")
assert result("G47") =~ expr("1.47e-140737488355328*f(140737488355328)")
assert result("F48") =~ expr("1.48e+281474976710656*f(281474976710656)")
assert result("G48") =~ expr("1.48e-281474976710656*f(281474976710656)")
assert result("F49") =~ expr("1.49e+562949953421312*f(562949953421312)")
assert result("G49") =~ expr("1.49e-562949953421312*f(562949953421312)")
assert result("F50") =~ expr("1.5e+1125899906842624*f(1125899906842624)")
assert result("G50") =~ expr("1.5e-1125899906842624*f(1125899906842624)")
assert result("F51") =~ expr("1.51e+2251799813685248*f(2251799813685248)")
assert result("G51") =~ expr("1.51e-2251799813685248*f(2251799813685248)")
assert result("F52") =~ expr("1.52e+4503599627370496*f(4503599627370496)")
assert result("G52") =~ expr("1.52e-4503599627370496*f(4503599627370496)")
assert result("F53") =~ expr("1.53e+9007199254740992*f(9007199254740992)")
assert result("G53") =~ expr("1.53e-9007199254740992*f(9007199254740992)")
assert result("F54") =~ expr("1.54e+18014398509481984*f(18014398509481984)")
assert result("G54") =~ expr("1.54e-18014398509481984*f(18014398509481984)")
assert result("F55") =~ expr("1.55e+36028797018963968*f(36028797018963968)")
assert result("G55") =~ expr("1.55e-36028797018963968*f(36028797018963968)")
assert result("F56") =~ expr("1.56e+72057594037927936*f(72057594037927936)")
assert result("G56") =~ expr("1.56e-72057594037927936*f(72057594037927936)")
assert result("F57") =~ expr("1.57e+144115188075855872*f(144115188075855872)")
assert result("G57") =~ expr("1.57e-144115188075855872*f(144115188075855872)")
assert result("F58") =~ expr("1.58e+288230376151711744*f(288230376151711744)")
assert result("G58") =~ expr("1.58e-288230376151711744*f(288230376151711744)")
assert result("F59") =~ expr("1.59e+576460752303423488*f(576460752303423488)")
assert result("G59") =~ expr("1.59e-576460752303423488*f(576460752303423488)")
assert result("F60") =~ expr("1.6e+1152921504606846976*f(1152921504606846976)")
assert result("G60") =~ expr("1.6e-1152921504606846976*f(1152921504606846976)")
assert result("F61") =~ expr("1.61e+2305843009213693952*f(2305843009213693952)")
assert result("G61") =~ expr("1.61e-2305843009213693952*f(2305843009213693952)")
assert result("F62") =~ expr("1.62e+4611686018427387904*f(4611686018427387904)")
assert result("G62") =~ expr("1.62e-4611686018427387904*f(4611686018427387904)")
*--#] float_extremes :
*--#[ MergeWithFloat :
* This tests MergeWithFloat in float.c
#: termsinsmall 16
Expand Down
4 changes: 2 additions & 2 deletions sources/float.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,11 @@ int UnpackFloat(mpf_t outfloat,WORD *fun)
f += ARGHEAD+6;
if ( f[-1] == -5 ) {
outfloat->_mp_exp =
-(mp_exp_t)((((ULONG)(f[-4]))<<BITSINWORD)+f[-5]);
-(mp_exp_t)((((ULONG)(f[-4]))<<BITSINWORD)+(UWORD)f[-5]);
}
else if ( f[-1] == 5 ) {
outfloat->_mp_exp =
(mp_exp_t)((((ULONG)(f[-4]))<<BITSINWORD)+f[-5]);
(mp_exp_t)((((ULONG)(f[-4]))<<BITSINWORD)+(UWORD)f[-5]);
}
}
/*
Expand Down