fix(python_file_finder): load gitignore from where CLI is invoked#380
Merged
mkniewallner merged 1 commit intofpgmaas:mainfrom May 10, 2023
Merged
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
=====================================
Coverage 96.0% 96.0%
=====================================
Files 37 37
Lines 1042 1042
Branches 207 207
=====================================
Hits 1001 1001
Misses 25 25
Partials 16 16
|
fpgmaas
approved these changes
May 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
.gitignoreis currently looked for based on the root directory passed as a CLI argument. This means that developers using asrcdirectory and invokingdeptrywithdeptry srcwon't benefit from gitignore being loaded.I don't think that there are a lot of use cases where
.gitignorewould be located in a different directory that the onedeptryis launched from, so this PR updates the behaviour so that.gitignoreis always loaded based on wheredeptryis invoked.If there really is a need for explicitly configuring the path to
.gitignore, we can think about adding an option later.Note that this PR will also facilitate the implementation of #381, even if doesn't strictly requires it, since we could also loop over each directory passed through the CLI.