feat: add ability to pass multiple source directories#381
Merged
mkniewallner merged 4 commits intofpgmaas:mainfrom May 10, 2023
Merged
feat: add ability to pass multiple source directories#381mkniewallner merged 4 commits intofpgmaas:mainfrom
mkniewallner merged 4 commits intofpgmaas:mainfrom
Conversation
4 tasks
795b2a6 to
9aeac27
Compare
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
=====================================
Coverage 96.0% 96.0%
=====================================
Files 37 37
Lines 1042 1044 +2
Branches 207 208 +1
=====================================
+ Hits 1001 1003 +2
Misses 25 25
Partials 16 16
|
fpgmaas
reviewed
May 10, 2023
fpgmaas
approved these changes
May 10, 2023
9aeac27 to
cc47574
Compare
Co-authored-by: Florian Maas <fpgmaas@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #177.
PR Checklist
docsis updatedDescription of changes
While not that common, some projects have multiple source directories, for instance if they define code used inside a web server in a dedicated directory, and code used in a dedicated Kubernetes job like a CRON in another dedicated directory.
In order to give more flexibility to developers, this PR updates
ROOTargument so that multiple paths can be passed on the CLI, like so:This won't break existing usages, since developers can still pass one directory as they are used to.