Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

[fix] Missed renaming a field in camelcase #2682

Merged
mattsse merged 1 commit into from
Nov 21, 2023
+1 −0
Merged

[fix] Missed renaming a field in camelcase #2682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ethers-core/src/types/transaction/optimism.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ pub struct DepositTransaction {

/// If true, the transaction does not interact with the L2 block gas pool.
/// Note: boolean is disabled (enforced to be false) starting from the Regolith upgrade.
#[serde(rename = "isSystemTx")]
Copy link
Contributor Author

@anikaraghu anikaraghu Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why do we not just use #[serde(rename_all = "camelCase")] at the top?

Copy link
Collaborator

@mattsse mattsse Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, this could have been avoided by using rename_all yes

pub is_system_tx: bool,
}

Expand Down