This repository was archived by the owner on Oct 19, 2024. It is now read-only.
[fix] Missed renaming a field in camelcase #2682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikaraghu
commented
Nov 20, 2023
|
|
||
| /// If true, the transaction does not interact with the L2 block gas pool. | ||
| /// Note: boolean is disabled (enforced to be false) starting from the Regolith upgrade. | ||
| #[serde(rename = "isSystemTx")] |
Contributor
Author
There was a problem hiding this comment.
out of curiosity, why do we not just use #[serde(rename_all = "camelCase")] at the top?
Collaborator
There was a problem hiding this comment.
good question, this could have been avoided by using rename_all yes
mattsse
approved these changes
Nov 21, 2023
|
|
||
| /// If true, the transaction does not interact with the L2 block gas pool. | ||
| /// Note: boolean is disabled (enforced to be false) starting from the Regolith upgrade. | ||
| #[serde(rename = "isSystemTx")] |
Collaborator
There was a problem hiding this comment.
good question, this could have been avoided by using rename_all yes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
is_system_txfield is not being renamed to camel case version like the other fields, and is causing issues since it is renamed in a different part of the code:ethers-rs/ethers-core/src/types/transaction/response.rs
Line 81 in 34030b3
Solution
Rename to camel case. It brings up a question though which is why we dont by default rename all fields in the struct? I can make this change if that's preferred.
By making this change, it allows the tests in this PR to pass: foundry-rs/foundry#6073
cc @mattsse
PR Checklist